[603] fix release workflow (philosowaffle#658)

* [603] fix release workflow

* add shell

* use workspace

* more debugging

* use dir

* try newer version and using relative path

* more debugging

* sanity check

* mkdir

* I hate this action

* let's try this

* last sanity check

* end state

* switch to v4

.github/actions/publish-ui-dist/action.yaml

@@ -46,10 +46,10 @@ runs:
       shell: pwsh
 
     # Create Build Artifact
-    - name: Upload Artifact ui_${{ inputs.os }}_${{ env.BUILD_VERSION }}
-      uses: actions/upload-artifact@v3
+    - name: Upload Artifact ui_${{ inputs.os }}_${{ github.run_number }}-${{ github.run_id }}
+      uses: actions/upload-artifact@v4
       with:
-        name: ui_${{ inputs.os }}_${{ env.BUILD_VERSION }}
+        name: ui_${{ inputs.os }}_${{ github.run_number }}-${{ github.run_id }}
         path: ${{ github.workspace }}/src/ClientUI/bin/Release/${{ inputs.framework }}/${{ inputs.os }}
 
 

.github/workflows/publish-release.yaml

@@ -71,21 +71,24 @@ jobs:
     runs-on: ubuntu-latest
     needs: [publish-ui-dist, publish-docker-images]
     steps:
-      - uses: actions/download-artifact@v3
+
+      - uses: actions/download-artifact@v4
         with:
           name: ${{ needs.publish-ui-dist.outputs.artifact_name }}
+          path: ${{ github.workspace }}/downloaded
+
       - name: Create Zip for Win UI Release Artifact
-        uses: papeloto/action-zip@v1
+        uses: vimtor/action-zip@v1.2
         with:
-          files: ${{ github.workspace }}/${{ needs.publish-ui-dist.outputs.artifact_name }}
-          dest: /dist/ui_win_${{ github.event.inputs.version }}.zip
+          files: /downloaded # must be relative to gh workspace, does not support absolute paths :(
+          dest: ui_win_${{ github.event.inputs.version }}.zip # this is hardcoded to output to ${{ github.workspace }}/ :(
 
       - uses: actions/checkout@v4
 
       - name: Create Release and Upload Artifacts
         uses: ncipollo/release-action@v1
         with:
-          artifacts: "${{ github.workspace }}/dist/ui_win_${{ github.event.inputs.version }}.zip"
+          artifacts: "${{ github.workspace }}/ui_win_${{ github.event.inputs.version }}.zip"
           token: ${{ secrets.GITHUB_TOKEN }}
           tag: v${{ github.event.inputs.version }}
           allowUpdates: true