Skip to content

Commit

Permalink
Fix nasa#219, define msgids via topicids
Browse files Browse the repository at this point in the history
The MsgID value is a conversion from TopicID
  • Loading branch information
jphickey committed Dec 7, 2023
1 parent 0d0cad0 commit cd24751
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 6 deletions.
8 changes: 7 additions & 1 deletion arch_build.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,14 @@ set(SAMPLE_APP_PLATFORM_CONFIG_FILE_LIST
# This makes them individually overridable by the missions, without modifying
# the distribution default copies
foreach(SAMPLE_APP_CFGFILE ${SAMPLE_APP_PLATFORM_CONFIG_FILE_LIST})
get_filename_component(CFGKEY "${SAMPLE_APP_CFGFILE}" NAME_WE)
if (DEFINED SAMPLE_APP_CFGFILE_SRC_${CFGKEY})
set(DEFAULT_SOURCE GENERATED_FILE "${SAMPLE_APP_CFGFILE_SRC_${CFGKEY}}")
else()
set(DEFAULT_SOURCE FALLBACK_FILE "${CMAKE_CURRENT_LIST_DIR}/config/default_${SAMPLE_APP_CFGFILE}")
endif()
generate_config_includefile(
FILE_NAME "${SAMPLE_APP_CFGFILE}"
FALLBACK_FILE "${CMAKE_CURRENT_LIST_DIR}/config/default_${SAMPLE_APP_CFGFILE}"
${DEFAULT_SOURCE}
)
endforeach()
11 changes: 6 additions & 5 deletions config/default_sample_app_msgids.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@
#ifndef SAMPLE_APP_MSGIDS_H
#define SAMPLE_APP_MSGIDS_H

/* V1 Command Message IDs must be 0x18xx */
#define SAMPLE_APP_CMD_MID 0x1882
#define SAMPLE_APP_SEND_HK_MID 0x1883
/* V1 Telemetry Message IDs must be 0x08xx */
#define SAMPLE_APP_HK_TLM_MID 0x0883
#include "cfe_core_api_base_msgids.h"
#include "sample_app_topicids.h"

#define SAMPLE_APP_CMD_MID CFE_PLATFORM_CMD_TOPICID_TO_MIDV(SAMPLE_APP_CMD_TOPICID)
#define SAMPLE_APP_SEND_HK_MID CFE_PLATFORM_CMD_TOPICID_TO_MIDV(SAMPLE_APP_SEND_HK_TOPICID)
#define SAMPLE_APP_HK_TLM_MID CFE_PLATFORM_TLM_TOPICID_TO_MIDV(SAMPLE_APP_HK_TLM_TOPICID)

#endif
30 changes: 30 additions & 0 deletions config/default_sample_app_topicids.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/************************************************************************
* NASA Docket No. GSC-18,719-1, and identified as “core Flight System: Bootes”
*
* Copyright (c) 2020 United States Government as represented by the
* Administrator of the National Aeronautics and Space Administration.
* All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License. You may obtain
* a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
************************************************************************/

/**
* @file
* SAMPLE_APP Application Topic IDs
*/
#ifndef SAMPLE_APP_TOPICIDS_H
#define SAMPLE_APP_TOPICIDS_H

#define SAMPLE_APP_CMD_TOPICID 0x82
#define SAMPLE_APP_SEND_HK_TOPICID 0x83
#define SAMPLE_APP_HK_TLM_TOPICID 0x83

#endif
1 change: 1 addition & 0 deletions mission_build.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ set(SAMPLE_APP_MISSION_CONFIG_FILE_LIST
sample_app_tbl.h
sample_app_tbldefs.h
sample_app_tblstruct.h
sample_app_topicids.h
)

if (CFE_EDS_ENABLED_BUILD)
Expand Down

0 comments on commit cd24751

Please sign in to comment.