Feature/multiple-binary #45
Conversation
Now it's capable of handling if binary name differs from reponame and also previous state will work as same as it was working.
updated issue with formatting in readme for line query_params -> bin.
|
This PR solves issue #42 . |
corrected wrong comment.
|
Thanks though how does this differ from ‘as’? |
|
But the above changes will handle which binary should be downloaded and, if one repository consists of more than one binary then we can specify which binary needs to download. For example in the case of monorepo, one repository can distribute two binaries for example, Repo Name: foobar Releasing: fb-client, fb-server It might be possible to distribute both within a single archive, but users may not need both and we are going to add junk to their system which will be never used in future. So to provide specific access users can download fb-client by bin=fb-client and similarly fb-server by bin=fb-server. Next combination that user can specify: action: download fb-client as fbc In the above both scenarios the repository is the same but distributing two binaries client and server through release. |
|
Oh i see, it selects a binary
Can we rename it to Select?
…On Tue, 27 Feb 2024 at 11:49 AM Abdhesh Nayak ***@***.***> wrote:
as handles the binary name in the local system. It doesn't have any
relationship with the release name. Downloading the same file doesn't
matter what value you are providing through as.
But the above changes will handle which binary should be downloaded and,
if one repository consists of more than one binary then we can specify
which binary needs to download.
For example in the case of monorepo, one repository can distribute two
binaries for example,
Repo Name: foobar
Releasing: fb-client, fb-server
It might be possible to distribute both within a single archive, but users
may not need both and we are going to add junk to their system which will
be never used in future.
So to provide specific access users can download fb-client by
bin=fb-client and similarly fb-server by bin=fb-server.
Next combination that user can specify:
action: download fb-server as fbs
Query: bin=fb-server&as=fbs
action: download fb-client as fbc
Query: bin=fb-client as fbc
In the above both scenarios the repository is the same but distributing
two binaries client and server through release.
—
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE2X45CN7WZWEGUT4K3CADYVUURTAVCNFSM6AAAAABD2RUQQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGU4TGOJQHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
| @@ -110,6 +110,7 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| User: "", | |||
| Program: "", | |||
| Release: "", | |||
| Selected: r.URL.Query().Get("select"), | |||
There was a problem hiding this comment.
As select is reserved keyword in golang, used selected and user can provide select as params.
|
Changes made accordingly, please check and review. |
|
Will this be merged? I'm trying to grab the omnictl binary from https://github.com/siderolabs/omni/releases/tag/v0.42.3 but right now I don't believe there's a way to specify that over the "omni" binaries. This PR sounds like it would allow me to do that. I can explore another option if this isn't going in but figured I'd check. Thanks! |
|
You can filter the assets with |
|
Implemented something like this in daba077 Sorry couldn't merge this, there was a bit more to it |
Thanks! That's exactly what I needed. |
Added Support for Binary Name via Query Params
Issue:
When a repository name differs from its binary release name, it could previously not be handled correctly. For example, if the repository name is
foobarbut the binary name isfb.Solution:
To address this issue, the parameter
?bin=has been introduced. This allows for the specification of the binary name directly in the query parameters.Behavior of Changes:
These changes do not affect any previous functionality. The addition of the
binparameter serves as an enhancement, allowing users who need to specify a different binary name to do so. This ensures compatibility and flexibility for various repository and binary naming conventions.