Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved volume control #374

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Conversation

mdingena
Copy link
Contributor

Changed from linear to logarithmic volume control. You will notice that the silent end of the volume bar is now less sensitive, and the loud end of the volume bar is now more sensitive. This source explains why linear volume control is bad and why logarithmic is awesome: http://dr-lex.be/info-stuff/volumecontrols.html
Make jPlayer more awesome, use this PR.

@maboa
Copy link
Member

maboa commented Jan 31, 2017

Hi mdingena - sorry for the delay in replying.

Thanks for your very cool logarithmic volume control.

We're just starting to build up steam again. In order to merge your PR can you please approve the CLA http://jplayer.org/cla/ ?

Cheers

Mark B

@maboa
Copy link
Member

maboa commented Jan 31, 2017

Actually this might be easier https://www.clahub.com/agreements/happyworm/jPlayer

@mdingena
Copy link
Contributor Author

I've signed it.

@maboa maboa merged commit 823e735 into jplayer:master Feb 3, 2017
@maboa
Copy link
Member

maboa commented Feb 3, 2017

Thanks so much mdingena, I've merged but for backwards compatibility reasons we may decide to have an option for logarithmic volume control and have it turned off by default. This is what we usually do for features like this.

@mdingena
Copy link
Contributor Author

mdingena commented Feb 3, 2017

That's fine. Happy to contribute! I've been using jPlayer for many years now with a custom skin and my sortable playlists hack #357. Take a look at that PR. It's jQuery specific though and I believe you guys want to go framework independent. But it might be enough to spark your interest or to put it on the roadmap for native jPlayer support. You can see my version of jPlayer in action at www.tjoonz.com </blatant self-promotion>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants