fix source RB issue #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vruusmann this PR was not merged for latest release, source is not yet reproducible (same for statsmodel and h2o, even if I did not yet prepare the PRs waiting for this one to get merged) |
Yep, I forgot to look into open GitHub issues while preparing for the 1.8.6 release.
Yep, the binary is reproducible, the source isn't.
There is currently no
No need to PR there - I have it mentioned in my internal TODO list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/jpmml/jpmml-xgboost/README.md
release rrequires a recent maven-source-plugin version
while at it, dropping not necessary timestamps: root one is sufficient
check with
mvn artifact:check-buildplan -Psonatype-oss-release