Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update iconography foundation pg.mdx #4356

Closed
wants to merge 7 commits into from
Closed

Update iconography foundation pg.mdx #4356

wants to merge 7 commits into from

Conversation

amritadesmet
Copy link
Contributor

@amritadesmet amritadesmet commented Oct 29, 2024 •
edited
Loading

  • Added Icon Variants description
  • Added Country symbol description
  • Add scaling section for icons + country symbols from Scale page
  • Inserted new images
  • Inserted all country symbols component

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0af6229

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:48pm

@amritadesmet amritadesmet mentioned this pull request Oct 31, 2024
Open
@amritadesmet
Update iconography.mdx
c75c44d 
Put in existing scale components for size icon and size base
mark-tate
mark-tate reviewed Nov 8, 2024
View reviewed changes
site/docs/foundations/iconography.mdx

The Salt design system has:

- 415 icons
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI these numbers will go stale, the next time we add a new icon.
Will we remember to update the numbers and keep this paragraph updated?
If so, great.
Otherwise.. we could say over 500 icons and 200 country symbols or something, or remove, altogether.

mark-tate
mark-tate reviewed Nov 8, 2024
View reviewed changes
site/docs/foundations/iconography.mdx

## Icon variants

Icons come in two variant types: **Outline** and **Solid**. Please note that all icons within the icon set have an outline variant, but 115 don’t have a solid variant.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"some don't have a solid variant", would be less effort to maintain

@joshwooding
Copy link
Contributor

Replaced by #4391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-tate mark-tate mark-tate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amritadesmet @joshwooding @mark-tate @origami-z