Skip to content

Change the repository structure to contain multiple packages #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

evgeny-osipenko
Copy link
Contributor

Resolves the issue #43.

@jprupp
Copy link
Owner

jprupp commented Sep 1, 2023

Hello Evegny,

I haven't looked at the code yet, but I would like to understand your goals with these changes. I can think of two possibilities:

  • Expose internal types and functions from this library in order to ease development of third-party packages providing additional features.
  • Allow extensions to this library to exist as separate packages, maintained by their own developers but hosted in this repository as their canonical locations.

With this information, I will set to review the request.

Greetings

@evgeny-osipenko
Copy link
Contributor Author

Yes, indeed, that's exactly the goals for this PR.

And #45 is exactly one of such extensions, which implements the recoverable signatures.

@evgeny-osipenko
Copy link
Contributor Author

@jprupp Is there any progress on reviewing this PR?

@jprupp
Copy link
Owner

jprupp commented Sep 20, 2023

I'm very sorry for the delay. The changes look good to me. When I'm back at a proper desktop computer, I'll merge these changes.

@jprupp
Copy link
Owner

jprupp commented Sep 20, 2023

I merged these changes plus a few additions using the command line, but GitHub isn't detecting it correctly. I'll close this pull request manually.

@jprupp jprupp closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants