Update readme.txt #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddparker
added a commit
that referenced
this pull request
Nov 2, 2011
Update readme.txt. Thanks agcolom
|
Hmmm....I don't know what is correct there. Any grammar police around? |
|
I would say that if it is the link that is shared then is should be shared. If "share link" is an entity, it should be share (but I'm not sure what a share link would be while I understand what a shared link would be)... But then I'm French, so not the best person to judge here ;-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one minor change ('be' missing) also wondering if point 2 should read:
When a user generates a share link OR When a user generates a shared link
The existing text says share I'm happy to change that if it should be shared, just let me know....