fix #125: IncompleteSelect can't handle collections with siblings

jrief · Apr 5, 2024 · 8a1a2fe · 8a1a2fe
1 parent 9c44f7b
commit 8a1a2fe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/formset/collection.py b/formset/collection.py
@@ -501,6 +501,11 @@ class FormCollection(BaseFormCollection, metaclass=FormCollectionMeta):
     `django.forms.forms.BaseForm` are managed by this class.
     """
     def get_field(self, field_path):
-        path = field_path.split('.', 1)
-        key, path = path
+        if self.has_many:
+            path = field_path.split('.', 2)
+            index, key, path = path
+            int(index)  # raises ValueError if index is not an integer
+        else:
+            path = field_path.split('.', 1)
+            key, path = path
         return self.declared_holders[key].get_field(path)
diff --git a/formset/views.py b/formset/views.py
@@ -36,7 +36,7 @@ def _fetch_options(self, request):
         field_path = request.GET['field']
         try:
             field = self.get_field(field_path)
-        except KeyError:
+        except (KeyError, ValueError):
             return HttpResponseBadRequest(f"No such field: {field_path}")
         assert isinstance(field.widget, (Selectize, DualSelector))
         widget = field.widget