Issue 176 alt #178
Merged
Issue 176 alt #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrincayc
commented
Jan 12, 2024
| if (have_x < 0) real_window_init(); \ | ||
| if (!have_x) { \ | ||
| err_logo(BAD_GRAPH_INIT,NIL); \ | ||
| return; \ |
There was a problem hiding this comment.
I wonder if this is going to cause an error to be missed somewhere?
There was a problem hiding this comment.
On the other hand, it possibly needs to return an error code to actually have this noticed?
jrincayc
commented
Jan 12, 2024
| int termcap_putter(char ch) { | ||
| *termcap_ptr++ = ch; | ||
| int termcap_putter(int ch) { | ||
| *termcap_ptr++ = (char)ch; |
There was a problem hiding this comment.
Should we be checking for non-char values here?
jrincayc
force-pushed
the
issue_176_alt
branch
from
0436176
to
d300824
Compare
|
I am tempted to add some warning comments and call this good. It is not code that is used by the main wxWidgets version, so I am less worried about breaking something here. (And the regular regression tests were able to run in x11 mode, and I checked that I could do my smoke test on it.) |
|
Reviewed changes and approve. This looks like a pragmatic approach to addressing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fixes for #176