Dolci/test concatenatevec tao #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmaddison
reviewed
Jul 17, 2024
Co-authored-by: James R. Maddison <[email protected]>
Co-authored-by: James R. Maddison <[email protected]>
Ig-dolci
commented
Jul 18, 2024
Ig-dolci
commented
Jul 18, 2024
Ig-dolci
commented
Jul 18, 2024
Ig-dolci
commented
Jul 18, 2024
pyadjoint/overloaded_type.py
Outdated
Comment on lines
145
to
155
| def _ad_assign(self, other): | ||
| """This method must be overridden. | ||
|
|
||
| The method should implement a routine for assigning the values from | ||
| another object `other` to `self`. | ||
|
|
||
| Args: | ||
| value (obj): The object which should be assigned to `self`. | ||
| """ | ||
| raise NotImplementedError | ||
|
|
There was a problem hiding this comment.
Only needed for mutable types (AdjFloat is immutable).
|
I think it's quicker for me to edit after merging into my fork. |
Yes. I agree. |
jrmaddison
requested changes
Jul 19, 2024
|
I think you can merge. FYI, I am using this firedrake branch: firedrakeproject/firedrake#3657 |
Ig-dolci
commented
Jul 19, 2024
Ig-dolci
commented
Jul 19, 2024
Ig-dolci
commented
Jul 19, 2024
Ig-dolci
commented
Jul 19, 2024
Ig-dolci
commented
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.