Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW SKETCH]: 2A13-BACKLIGHT_CONTROLLER.ino #99

Conversation

Arribe
Copy link
Collaborator

@Arribe Arribe commented Mar 26, 2024

Description

Initial start at backlighting code. Comments not done, and only coded for 2 panels on the UIP for an example of how BL channels with multiple annunciators could be handled. LED strings with mostly just backlighting will be simpler, and the BL code may need to be pulled up a level out of the panel specific headers to reflect that the internal lights console's instrument knobs drive multiple panels at once.

Closes #

Dependencies

  • List any dependencies that are required for this change, including a full list of libraries required, especially if it is a new or otherwise unused library in the OpenHornet software.

Type of change

  • New software module (new software module for slave)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update outside of the automatically-generated Doxygen documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have complied with the software manual for this project
  • I have performed a self-review of my own code
  • I have commented my code fully with Doxygen compatible comments, particularly in hard-to-understand areas
  • I have made corresponding changes to non-Doxygen generated documentation
  • I have ran Doxygen locally, and it builds the docs successfully
  • My changes generate no errors on compile in Arduino IDE
  • My changes generate no new warnings on compile in Arduino IDE
  • Any dependent changes have been merged and published in downstream modules
  • (For sketches only) This sketch complies with OH-INTERCONNECT v10
  • If this sketch requires additional libraries, I have added it as a sub-module per the Arduino Libraries section of the Software Manual.

How Has This Been Tested?

  • I have tested the sketch in-circuit in DCS with DCS-BIOS and outputs (displays, LEDs, etc.) function as expected.
  • I have tested the sketch in-circuit in DCS with DCS-BIOS and HID inputs (switches, pots, etc.) function as expected, with switches moving the correct direction.
  • I have tested the sketch in-circuit in DCS with DCS-BIOS and any logic in the sketch has been tested and functions as expected.
  • This code has not yet been tested in-circuit.
  • This code has not yet been tested in DCS-BIOS.

Description of Testing

Initial DCS Bios testing with sim running. Master Arm backlighting with brightness control works via the instr lighting panel. The annunciators work with the correct colors using the light test switch.

Test Configuration

  • Firmware version:
  • Hardware: 0.2.0
  • Toolchain:
  • SDK: DCS Bios FP 0.3.9

@jrsteensen jrsteensen added Type: Enhancement New feature or request. Category: Embedded This issue affects a specific embedded microcontroller software (i.e. an Arduino Sketch). labels Mar 26, 2024
@jrsteensen jrsteensen added this to the v0.1.0 milestone Mar 26, 2024
@jrsteensen jrsteensen linked an issue Mar 26, 2024 that may be closed by this pull request
16 tasks
removed joystick library due to CI failure note.
@jrsteensen jrsteensen marked this pull request as draft March 26, 2024 05:17
Arribe added 8 commits March 26, 2024 12:20
onInstPnlDimmerChange controls multiple backlighting channels so needs to be at the top level header so it can fill in the associated UIP/LIP backlighting channel's panels.
Updated comments and added HUD Panel header.
Added R EWI panel, and updated hud panel to account for my Rev3 hardware using a define.  Listed the Rev3 as a todo to remove when finished with programming/testing.
@jrsteensen jrsteensen changed the title Feature new sketch 2 a13 backlight controller [NEW SKETCH]: 2A13-BACKLIGHT_CONTROLLER.ino Apr 4, 2024
@jrsteensen jrsteensen marked this pull request as ready for review September 30, 2024 16:08
@jrsteensen
Copy link
Owner

Approved as POC for UIP backlighting. Still need LIP and L/R Consoles to close the issue.

@jrsteensen jrsteensen merged commit 109028c into jrsteensen:develop Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Embedded This issue affects a specific embedded microcontroller software (i.e. an Arduino Sketch). Type: Enhancement New feature or request.
Projects
Development

Successfully merging this pull request may close these issues.

[NEW SKETCH]: 2A13-BACKLIGHT_CONTROLLER.ino
2 participants