Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es.js.org #8613

Merged
merged 1 commit into from
Nov 6, 2023
Merged

es.js.org #8613

merged 1 commit into from
Nov 6, 2023

Conversation

enzonotario
Copy link
Contributor

@MattIPv4 MattIPv4 changed the title Add es.js.org es.js.org Oct 31, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Oct 31, 2023
@enzonotario
Copy link
Contributor Author

enzonotario commented Oct 31, 2023

Hi there!

I tried to do so, but it says:

The custom domain `es.js.org` is already taken. If you are the owner of this domain, check out https://docs.github.com/pages/configuring-a-custom-domain-for-your-github-pages-site/verifying-your-custom-domain-for-github-pages for information about how to verify and release this domain.

I saw that in previous cases you mentioned contacting GitHub Support. I will contact them and get back. Thank you!

@enzonotario
Copy link
Contributor Author

Hi there! I've contacted GitHub Support, and they've informed me that they need to verify the domain through a TXT record in the DNS. I showed them this PR to see if they could handle it from their end, but they say they require the TXT record.

Could you please assist me with this? GitHub is instructing me to:

Create a TXT record in your DNS configuration for the following hostname:
_github-pages-challenge-es-js.es.js.org

Use this code for the value of the TXT record:
64eb9dc217adba5f1cff49946b626a

Thank you!

@indus
Copy link
Member

indus commented Nov 2, 2023

@enzonotario I've just added the TXT record

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation labels Nov 2, 2023
@indus
Copy link
Member

indus commented Nov 2, 2023

I've also already added your requested subdomain to JS.ORGs zonefile. But the CNAME in your branch with the single line es.js.org is required to make it work.
I'll merge after we have "contact". Please keep this PR open.

@enzonotario
Copy link
Contributor Author

Thanks @indus , I've added the CNAME file in the branch.

@indus
Copy link
Member

indus commented Nov 2, 2023

for some reason github still redirects to a 8 year old page without content: https://es.js.org/

@indus
Copy link
Member

indus commented Nov 2, 2023

Did it say something about the CNAME beeing taken this time?

@indus
Copy link
Member

indus commented Nov 2, 2023

It looks like cloudflare is having some preoblems as well. Maybe it just takes some time to propagate. I will check again tomorrow.

@enzonotario
Copy link
Contributor Author

Ok, thanks! From my end, it says that it's verified:

image

But ok, lets wait. I also have asked to them. Thanks again!

@indus
Copy link
Member

indus commented Nov 3, 2023

No improvment! Hm - the CNAME record is in the zonefile:
grafik
and it points to es-js.github.io and not jamiedixon.github.io

@enzonotario would you mind to reach out to GH support again. I think there is something messed up on their side...

@enzonotario
Copy link
Contributor Author

Hi there!

I've contacted GitHub Support. This is what they said:

GitHub Support Response

I can see in the screenshot on the issue you linked, they had the proxy enabled for the record. Using the proxy with GitHub Pages is not supported. Cloudflare enables their HTTP/DNS proxy feature by default, meaning GitHub isn't able to see the DNS records required to generate an HTTPS certificate. You'll need to disable this for any DNS records that point towards GitHub.
Disclaimer: Disabling the HTTP/DNS proxy may interfere with other Cloudflare services. If you use other Cloudflare services with your site, we aren't able to guarantee that these will continue working. For more help with this, I'd recommend reaching out to Cloudflare's support team.

About the redirect, once a domain is verified it can take up to 7 days for the domain to be released from it's previous repository, so that's likely why you're still seeing that.

As I can confirm that the es-js org has verified the domain, I was able to release the domain from it's previous section, bypassing this 7 day window for you automatically.

Once the CNAME record is rectified in my above steps, you should be clear to re-add the domain (if not done already) and continue with the standard process of enabling HTTPS, etc.

So far, I can see it's now returning 404, instead of the old-site that was returning previously.

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Nov 6, 2023
@indus
Copy link
Member

indus commented Nov 6, 2023

@enzonotario For me it is working now.
Welcome https://es.js.org

@indus indus merged commit 3314a5a into js-org:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants