Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solved 3rd module #4

Merged
merged 1 commit into from
Oct 2, 2024
Merged

solved 3rd module #4

merged 1 commit into from
Oct 2, 2024

Conversation

ShmigelskiyAndrey
Copy link
Contributor

No description provided.

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 1, 2024

Добавляю преподавателя (@koalex) для код-ревью.

@jsru-1 jsru-1 requested a review from koalex October 1, 2024 20:00
koalex
koalex approved these changes Oct 2, 2024
View reviewed changes
3-module/5-task/index.js
let elems = str.split(' ').filter(elem => !isNaN(elem));

return { min: Math.min.apply(null, elems),
max: Math.max.apply(null, elems),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно так:
Math.max(...elems);

@jsru-1 jsru-1 merged commit 8f9968a into js-tasks-ru:master Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koalex koalex koalex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShmigelskiyAndrey @jsru-1 @koalex