Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solving basic tasks (creating app & weather) #2

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Solving basic tasks (creating app & weather) #2

merged 2 commits into from
Oct 1, 2024

Conversation

DariaaaP
Copy link
Contributor

@DariaaaP DariaaaP commented Oct 1, 2024

  1. Created a new app with the output of a string with the current date;
  2. Fixed the display of weather cards depending on different conditions.

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 1, 2024

Добавляю преподавателя (@ShGKme) для код-ревью.

@jsru-1 jsru-1 requested a review from ShGKme October 1, 2024 14:23
ShGKme
ShGKme approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

01-basics/10-create-app/script.js
return { formatAsLocalDate }
},

template: `<div>Сегодня {{formatAsLocalDate(new Date())}}</div>`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text interpolation is always used with spaces: {{ formatAsLocalDate(new Date()) }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the next problem

@jsru-1 jsru-1 merged commit e0ae756 into js-tasks-ru:master Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DariaaaP @jsru-1 @ShGKme