Задачи CreateApp, WeatherApp, CounterApp и MapApp #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавляю преподавателя (@ShGKme) для код-ревью. |
ShGKme
approved these changes
Oct 4, 2024
Comment on lines
+19
to
+26
| const timeToTimestamp = (time) => { | ||
| return Date.parse('1970-01-01T' + time) | ||
| } | ||
|
|
||
| const isNignt = (dt, sunrise, sunset) => { | ||
| const ts = timeToTimestamp(dt); | ||
| return ts < timeToTimestamp(sunrise) || ts > timeToTimestamp(sunset) | ||
| } |
There was a problem hiding this comment.
Строки в формате HH:MM можно сравнивать просто лексикографически как строки без преобразований. '08:30' < '09:12'
Comment on lines
+44
to
+47
| :class="{ | ||
| 'weather-card': true, | ||
| 'weather-card--night': isNignt(row.current.dt, row.current.sunrise, row.current.sunset) | ||
| }" |
There was a problem hiding this comment.
Статические классы, которые всегда есть у элемента, можно описывать явно в шаблоне через обычный атрибут class="weather-card". Так будет видно и основные классы верстки, и какие классы определяются динамически.
Comment on lines
+70
to
+75
| <div class="weather-details__item" v-for="details in [ | ||
| {label: 'Давление, мм рт. ст.', value: pressureHpaToMmhg(row.current.pressure)}, | ||
| {label: 'Влажность, %', value: row.current.humidity}, | ||
| {label: 'Облачность, %', value: row.current.clouds}, | ||
| {label: 'Ветер, м/с', value: row.current.wind_speed}, | ||
| ]"> |
There was a problem hiding this comment.
Лучше такие большие значения выносить в setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В задачу CreateApp внёс поправки по вашим рекомендациям