Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Attempt to add rollup arm64 as dependency to rollup
Results in same error. Rollup declares an optional dependency on the arm64 variant. ``` pnpm install && bazelisk run //:vite -- --help private/var/tmp/_bazel_joe/1713d43747a35eb7e2009bc8fd9406b7/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/vite_/vite.runfiles/_main/node_modules/.aspect_rules_js/[email protected]/node_modules/rollup/dist/native.js:63 throw new Error( ^ Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory. at requireWithFriendlyError (/private/var/tmp/_bazel_joe/1713d43747a35eb7e2009bc8fd9406b7/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/vite_/vite.runfiles/_main/node_modules/.aspect_rules_js/[email protected]/node_modules/rollup/dist/native.js:63:9) ``` It looks like rules_js doesn't link optional dependencies and also doesn't use the package.json `pnpm.packageExtensions` override. ``` ls -lh $BAZEL_OUT/darwin_arm64-fastbuild/bin/vite_/vite.runfiles/_main/node_modules/.aspect_rules_js/[email protected]/node_modules drwxr-xr-x@ 3 joe wheel 96B Nov 7 13:35 @types lrwxr-xr-x@ 1 joe wheel 176B Nov 7 13:35 rollup -> $BAZEL_OUT/darwin_arm64-fastbuild/bin/node_modules/.aspect_rules_js/[email protected]/node_modules/rollup ``` https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1731014606302199?thread_ts=1730916056.708769&cid=CEZUUKQ6P
- Loading branch information