Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Updates #2

wants to merge 9 commits into from

Conversation

chmorgan
Copy link

Hello.

Here are some changes I've made when using the library if you are interested in pulling them upstream. Note that I did change the license early on and I can appreciate that this may make the changes not interesting to you. If you'd like to discuss please msg me here.

Chris

@timyardley
Copy link

I’m not an expert in licensing but I believe you must keep the original authors MIT copyright statement intact

@chmorgan
Copy link
Author

chmorgan commented Apr 11, 2018 via email

…Secret to better match Nest documentation and REST api usage

Update usage to reflect rename
… NestCam

Add the Camera struct and add it to the appropriate REST structures
…s on POST, GET, and PUT

The PUT redirect support looks like it can be removed as Go 1.8 supports redirection. I'll retest
once F26 is out in a few days as it inclues 1.8.
…kRedirect function on PUTs

Also refactor httpClient to reduce code duplication
Start with Devices.FindThermostat() a helper to find thermostats by their name
@chmorgan
Copy link
Author

Dropped the license changes off, apologizes for my misunderstanding there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants