Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to check smach output #85

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

add test to check smach output #85

wants to merge 8 commits into from

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Jun 20, 2020

  • test/2013_fridge_demo.test test/structuretest

k-okada
k-okada commented Jun 20, 2020
View reviewed changes
Copy link
Member Author

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naoki-Hiraoka せっかく直したコードを他の人がrevertしちゃうようなことがなくて，将来の自分を守ることになるので，どのようにしたら最小限の手間でテストを作れるか考えるのが良くて，例えばhttps://github.com/ros/ros_comm/blob/noetic-devel/tools/rostest/nodes/publishtest でpublishしているかどうかだけ調べれば，途中でノードが死んでいるか分かったりするんだけど，何がいいだろうか？

ということで１つの案はcontainer_structureがあっているかどうかを調べるものを作ってみました．
#78
はこれでテストに成る気がする．
#81
も同じかな．
#80 はそもそも途中でエラーになっているのかな？

@k-okada k-okada changed the title add test to check pddl output add test to check smach output Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-okada @Naoki-Hiraoka