Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize :wait-interpolation-smooth #356

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pazeshun
Copy link
Collaborator

@pazeshun pazeshun commented Jul 13, 2018

Enable :wait-interpolation-smooth to support all cases in start-jsk/rtmros_common#1052 (comment)

  • Exit from the method at the correct timing even if feedback from joint trajectory action is not published
  • Don't relay on time_from_start of feedback because this value varies by robot

Fix :wait-interpolation-smooth to work in kinematics simulator of roseus.

  • Without this PR, :wait-interpolation-smooth in simulator exits immediately after called.

(Minor Fix) Fix return value of :wait-interpolation-smooth to the same as :wait-interpolation

  • Return value is a list of interpolatingp for all controllers
    • The list may include t because interpolation may not finish
  • Fix test to follow this change because test assumed :wait-interpolation-smooth returns nil

@pazeshun
Copy link
Collaborator Author

Tested with...

  • PR2
  • Baxter (with gripper)
  • Fetch
  • HIRONX (simulation)

@pazeshun pazeshun self-assigned this Jul 24, 2018
@mmurooka
Copy link
Member

Could you test with HRP2 or other robot using hrpsys-base?
https://github.com/start-jsk/rtmros_hrp2/blob/master/README.md is manual to use HRP2 simulator and real robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants