[naoqieus/cross] use $ROS_DISTRO instead of melodic when installing pepper_meshes to allow us to use ROS noetic for build cross environment #1847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related commit:
kochigami@1a0cfe0
#1583
When I used ubuntu 20.04 + ROS noetic PC,
./build_user.sh
of pepper cross failed.That is because this script tries to copy
/opt/ros/melodic/share/pepper_meshes/meshes/
forcefully.kochigami@kochigami-pc:~/catkin_ws/src/jsk_robot/jsk_naoqi_robot/cross$ ./build_user.sh
Therefore, I changed
melodic
to$ROS_DISTRO
in https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_naoqi_robot/cross/build_user.sh#L45-L52.When I checked
cross/i386_User/src/pepper_meshes/package.xml
, version 0.2.5 was installed.