Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop/fetch] [jsk_robot_startup] Record image topic to mongodb every time #1883

Merged
merged 9 commits into from
Oct 26, 2023
Merged

[develop/fetch] [jsk_robot_startup] Record image topic to mongodb every time #1883

merged 9 commits into from
Oct 26, 2023

Conversation

tkmtnt7000
Copy link
Member

This PR enables robot to record image topic to mongodb every time.

Original PR to master branch is #1792, and I adopted to fetch's enviroment.

@tkmtnt7000 tkmtnt7000 marked this pull request as draft October 25, 2023 07:01
@github-actions github-actions bot added the Fetch label Oct 25, 2023
@tkmtnt7000
[jsk_robot_startup][jsk_fetch_startup
a45a312 
] Change nodelet name to adjust existing nodelet
@tkmtnt7000 tkmtnt7000 marked this pull request as ready for review October 25, 2023 09:54
@tkmtnt7000
Copy link
Member Author

Ready for review.

@tkmtnt7000 tkmtnt7000 changed the title [WIP] [develop/fetch] [jsk_robot_startup] Record image topic to mongodb every time [develop/fetch] [jsk_robot_startup] Record image topic to mongodb every time Oct 25, 2023
@tkmtnt7000
Copy link
Member Author

tkmtnt7000 commented Oct 26, 2023 •
edited
Loading

Could you review this? @sktometometo @mqcmd196
岡田先生がこの機能を使って遊ぶために可能であれば画像を貯めるノードを常時起動させておきたいとのことです

@mqcmd196 mqcmd196 self-requested a review October 26, 2023 03:39
mqcmd196
mqcmd196 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@mqcmd196 mqcmd196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tkmtnt7000
Copy link
Member Author

Thank you!

@tkmtnt7000 tkmtnt7000 merged commit 8a26afc into jsk-ros-pkg:develop/fetch Oct 26, 2023
5 of 9 checks passed
@tkmtnt7000 tkmtnt7000 deleted the record-image-every-time branch October 26, 2023 03:43
@tkmtnt7000 tkmtnt7000 added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com/hacktoberfest-update label Oct 26, 2023
@tkmtnt7000 tkmtnt7000 mentioned this pull request Nov 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mqcmd196 mqcmd196 mqcmd196 approved these changes

Assignees
No one assigned
Labels
develop/fetch Fetch hacktoberfest-accepted https://hacktoberfest.digitalocean.com/hacktoberfest-update jsk_robot_startup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkmtnt7000 @mqcmd196 @k-okada