Add The Neverending Story FlexDMD #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add FlexDMD to Cabinet Mode
|
Mind renaming this pr to mention the table name? |
|
Mind adding the table url to the PR description? |
Changed filename to .vbs.dmd to meet naming convention.
Edit to fix error on standard res FlexDMD
|
Can you also rename the patch file to contain |
|
The downloaded file is |
|
Looks like the embedded dmd no longer shows scores? |
Changed names to reflect table download name. Changed .vbs.patch to .vbs.dmd.patch
I believe that's as intended. There's a change that can be made to the asset in vpx to fill that in. I can try to modify the script to address that but the solution is to change the asset. |
|
Asset is Wall54, backwall_noDMD |
|
So #332 behaves the same? Found it strange that images do work. |
francisdb
reviewed
Nov 4, 2024
| + DMDScene.AddActor FlexDMD.NewImage("Dig" & i, "VPX.dempty&dmd=2") | ||
| + Digits(i).Visible = False | ||
| + Next | ||
| + digitgrid.Visible = False |
|
Oh what the hell I changed that. Will fix. Again.
…On Mon, Nov 4, 2024, 11:07 AM Francis De Brabandere < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In The Neverending Story(Original 2021) v1/The Neverending Story
(Original 2021).vbs.dmd.patch
<#331 (comment)>
:
> ++ Else
++ FlexDMD.TableFile = Table1.Filename & ".vpx"
++ FlexDMD.RenderMode = 2
++ FlexDMD.Width = 128
++ FlexDMD.Height = 32
++ FlexDMD.Clear = True
++ FlexDMD.GameName = cGameName
++ FlexDMD.Run = True
++ Set DMDScene = FlexDMD.NewGroup("Scene")
++ DMDScene.AddActor FlexDMD.NewImage("Back", "VPX.bkborder")
++ DMDScene.GetImage("Back").SetSize FlexDMD.Width, FlexDMD.Height
++ For i = 0 to 35
++ DMDScene.AddActor FlexDMD.NewImage("Dig" & i, "VPX.dempty&dmd=2")
++ Digits(i).Visible = False
++ Next
++ digitgrid.Visible = False
Same fix required here?
—
Reply to this email directly, view it on GitHub
<#331 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADX57UK2ZCPBVGHI6WLNIXLZ66LUBAVCNFSM6AAAAABQ7FGBXWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJTGQ4DKMZUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
fixed digitgrid again
|
@jsm174 I think this is ok to go |
|
@evilwraith - awesome!! @francisdb - thanks for working with @evilwraith on this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FlexDMD to Cabinet Mode for The Neverending Story
Original table here:
https://vpuniverse.com/files/file/15488-neverending-story-mod/