Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to all public APIs #184

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tkukushkin
Copy link

@tkukushkin tkukushkin commented Jul 11, 2023

fixes #146

I used pyright --verifytypes to check type completeness of public API. Unfortunately I had to move tests to a separate package to exclude them from pyright check.

@charettes
Copy link

If that can be of any help I confirm the types provided in this PR addressed the issues we were running into with @stats.Timer decoration of function having loose their return type and preventing type checkers from doing their job.

@chuangfengwang
Copy link

Valuable work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type hints & PEP 561 packaging
4 participants