-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug: Indentation problems with JsonEditor component #456
Labels
🐛 Bug
Indicates that the issue is a bug or defect.
Status: In Progress
This issue is being worked on, and has someone assigned.
Comments
@benjagm I'll start working on this right away. |
Thanks @Adity20 !! |
@benjagm jsonc format is causing some formatting issue with this component. I am done with all changes for other components and the overflow issue also but there is some issue with this code component. |
Thanks!! Please submit the PR and I'll take a look. |
Okay @benjagm |
This comment was marked as resolved.
This comment was marked as resolved.
Closed in favour of #560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐛 Bug
Indicates that the issue is a bug or defect.
Status: In Progress
This issue is being worked on, and has someone assigned.
Describe the bug
We had issues in the past with the JsonEditor component in small devices because it produced horizontal overflow. For this reason we needed to disable the wrapLines and wrapLongLines attributes in this commit cd30786 but this is producing unexpected indentation issues like the one discussed here.
The component is this one:
https://github.com/json-schema-org/website/blob/main/components/JsonEditor.tsx
The solution we expect is enable wrapLines and wrapLongLines and add a horizontal scroll bar in component so we producer the best developer experience in all code snippets.
Steps To Reproduce
Any page with code snippets in mobile devices.
Expected Behavior
Horizontal scroll bar at the bottom of the component.
Screenshots
No response
Device Information [optional]
Are you working on this issue?
No
Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)
No
The text was updated successfully, but these errors were encountered: