Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Indentation problems with JsonEditor component #456

Closed
benjagm opened this issue Mar 5, 2024 · 7 comments
Closed

🐛 Bug: Indentation problems with JsonEditor component #456

benjagm opened this issue Mar 5, 2024 · 7 comments
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@benjagm
Copy link
Collaborator

benjagm commented Mar 5, 2024

Describe the bug

We had issues in the past with the JsonEditor component in small devices because it produced horizontal overflow. For this reason we needed to disable the wrapLines and wrapLongLines attributes in this commit cd30786 but this is producing unexpected indentation issues like the one discussed here.

The component is this one:
https://github.com/json-schema-org/website/blob/main/components/JsonEditor.tsx

The solution we expect is enable wrapLines and wrapLongLines and add a horizontal scroll bar in component so we producer the best developer experience in all code snippets.

Screenshot 2024-03-05 at 18 32 09

Screenshot 2024-03-05 at 18 32 52

Steps To Reproduce

Any page with code snippets in mobile devices.

Expected Behavior

Horizontal scroll bar at the bottom of the component.

Screenshots

No response

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

@benjagm benjagm added 🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage. labels Mar 5, 2024
@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Triage This is the initial status for an issue that requires triage. labels Mar 5, 2024
@benjagm benjagm moved this to In Progress in Website Contributor Board Mar 5, 2024
@Adity20
Copy link
Contributor

Adity20 commented Mar 5, 2024

@benjagm I'll start working on this right away.

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 5, 2024

Thanks @Adity20 !!

@Adity20
Copy link
Contributor

Adity20 commented Mar 8, 2024

@benjagm jsonc format is causing some formatting issue with this component. I am done with all changes for other components and the overflow issue also but there is some issue with this code component.
Screenshot 2024-03-08 150504

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 8, 2024

Thanks!! Please submit the PR and I'll take a look.

@Adity20
Copy link
Contributor

Adity20 commented Mar 8, 2024

Okay @benjagm

@Adity20

This comment was marked as resolved.

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 20, 2024

Closed in favour of #560

@benjagm benjagm closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in Website Contributor Board Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants