resolved code formatting issue #371 #385

Adity20 · 2024-02-28T12:56:23Z

GitHub Issue: #371

Summary: This pull request is being made proactively to fix a particular problem which is code formatting for the issue #371.
Resolves #371

the UI looks like this now and if any other changes are required kindly let me @benjagm.

@benjagm kindly review my PR

gregsdennis · 2024-02-28T20:11:34Z

pages/draft/2020-12/release-notes.md

@@ -196,7 +200,7 @@ Here's how you would covert a schema using `$recursiveRef` to use `$dynamicRef`.
            }
          }
        }
-        // strict-tree schema, guards against misspelled properties
+      // strict-tree schema, guards against misspelled properties


Looks like there's still an issue with syntax highlighting. Probably is this comment.

Can you change the language specifier to jsonc to see if that fixes the issue?

Adity20 · 2024-02-29T03:03:12Z

Sure @gregsdennis I'll try that too.

Adity20 · 2024-02-29T11:05:20Z

Hi @gregsdennis I have tried some changes and now the UI looks like this

kindly review it and let me know if some more changes are required

gregsdennis · 2024-03-01T19:35:36Z

pages/draft/2020-12/release-notes.md

      ```json
-        // tree schema, extensible
+<<<<<<< HEAD


Looks like there's an incomplete merge in here.

gregsdennis · 2024-03-01T19:36:26Z

pages/draft/2020-12/release-notes.md

+    <td>
+
+      ```json
+        {


It looks like the indention is being rendered. Can you pull this back to the start of the line, please?

sure @gregsdennis i'll make the changes asap

can you check now @gregsdennis

Did you push the changes? I don't see a difference in the code. Also, could you provide a screenshot? I can't run the site locally.

but at my end its showing the changes

here are the screenshots

and the output of these changes

I don't see the indention changes I asked for. This is what's confusing.

Please move the JSON all the way to the left, ignoring the HTML indentation.

Now fine @gregsdennis ?

There's still some indention. Please pull all the way to the left.

Adity20 · 2024-03-02T16:45:10Z

Hi @gregsdennis I changed the format to jsonc and now the output looks like this kindly check

gregsdennis · 2024-03-02T19:25:59Z

What's going on here?

Also, the indentation seems to have been messed up on the 2020-12 and completely removed on the 2019-09. It's almost as if it's rendering spaces with variable width.

This is very confusing; the code looks fine to me. Thanks for hanging in on this one.

Adity20 · 2024-03-03T03:06:20Z

Now fine @gregsdennis ?

gregsdennis · 2024-03-03T03:11:55Z

The code looks good, but it still doesn't render right. The code has the correct indentation, but the render shows none.

Adity20 · 2024-03-03T03:15:56Z

So what should I do now?

This reverts commit 78e51da.

This reverts commit 8255639.

This reverts commit 55dd827.

This reverts commit ac7f824, reversing changes made to 78e51da.

This reverts commit d0d5244.

This reverts commit c114d89.

benjagm · 2024-03-03T10:17:18Z

Maybe this is related with the problems here:

There are 2 config attributes in the code editor I needed to change to avoid extra width of the containing page for some scenarios for small devices, but the solution was suboptimal. I think this is related. Below the commit I did:
cd30786

related (maybe): react-syntax-highlighter/react-syntax-highlighter#376

Adity20 · 2024-03-03T11:10:44Z

Maybe this is related with the problems here:

There are 2 config attributes in the code editor I needed to change to avoid extra width of the containing page for some scenarios for small devices, but the solution was suboptimal. I think this is related. Below the commit I did: cd30786

related (maybe): react-syntax-highlighter/react-syntax-highlighter#376

Is this related to issue #393?

benjagm · 2024-03-03T11:25:40Z

The problem is with indentation right? Those 2 parameters affects exactly that. First play with them, later well need to check how to make sure the component's behavior is correct in other pages, specifically in small devices.

Adity20 · 2024-03-03T11:31:40Z

Okay @benjagm I'll try that too.

benjagm · 2024-03-04T18:24:28Z

@Adity20 did you tested the component indentation disabling the attributes wrapLines and wrapLongLines? I think that can fix it.

Adity20 · 2024-03-04T18:41:20Z

Yes I am testing out all the changes as you mentioned @benjagm will be done by tomorrow.

Adity20 · 2024-03-05T06:30:21Z

I tried disabling these two attributes and tried some other changes too but that's creating an overflow in the page as the code is taking more space now to be in the same line.
I don't think this will work we'll have to apply more custom styles maybe @benjagm

gregsdennis · 2024-03-05T07:03:07Z

Can we have each section scroll horizontally? Would it be weird to have that here but not in other places?

Alternatively, what if we made it look like a git diff, where you do a red - line followed by a green +line? Is that possible?

benjagm · 2024-03-05T07:05:28Z

Can we have each section scroll horizontally? Would it be weird to have that here but not in other places?

Alternatively, what if we made it look like a git diff, where you do a red - line followed by a green +line? Is that possible?

I'd suggest fix everything but the indentation issue here and create an different issue to configure the code component to have its own horizontal scroll bar se fix this across the entire site.

gregsdennis · 2024-03-05T07:12:13Z

I'm happy with that

Adity20 · 2024-03-05T09:57:16Z

So I should try horizontal scrollbar once or keep trying some other changes?

benjagm · 2024-03-05T16:30:19Z

@Adity20 I think si better to do it in a separate issue. Let suggest this:

Let's approve this leaving the indentation unfixed.
I'll open the issue and assign it to you if this is ok for you.

benjagm

Great job @Adity20 !!!

Adity20 · 2024-03-05T16:47:08Z

Yeah that works for me @benjagm. I can start working on the that one then.
And thanks for constant support always.

benjagm · 2024-03-05T17:34:20Z

@Adity20 please add a comment in #456 to get assigned.

gregsdennis

Everything except the indentation seems to be resolved. I'm happy address that elsewhere.

Adity20 added 2 commits February 28, 2024 18:22

resolved code formatting issue json-schema-org#371

2794d5e

resolved code formatting issue json-schema-org#371

1101d12

gregsdennis requested changes Feb 28, 2024

View reviewed changes

benjagm added the Status: In Progress This issue is being worked on, and has someone assigned. label Feb 29, 2024

Adity20 and others added 3 commits February 29, 2024 16:39

added the proper formatting

86e8c55

Merge branch 'main' of https://github.com/Adity20/website

3fdb3cd

Merge branch 'json-schema-org:main' into main

69945d2

Adity20 requested a review from gregsdennis March 1, 2024 06:14

gregsdennis requested changes Mar 1, 2024

View reviewed changes

Adity20 added 3 commits March 2, 2024 11:25

added proper headings

80ff2cf

Merge branch 'main' of https://github.com/Adity20/website

6d4172b

changed the indentation of json

965ed9d

changed the format to jsonc

7fa4d3c

changed some indetation

d7575ad

Adity20 and others added 9 commits March 3, 2024 10:04

overflow in blog space handled

78e51da

Merge branch 'main' into main

ac7f824

handled overflow

892a1b2

changes

8255639

Revert "overflow in blog space handled"

d187358

This reverts commit 78e51da.

Revert "changes"

7ffd572

This reverts commit 8255639.

reverting

55dd827

Revert "reverting"

de1f547

This reverts commit 55dd827.

Revert "Merge branch 'main' into main"

c114d89

This reverts commit ac7f824, reversing changes made to 78e51da.

Adity20 added 5 commits March 3, 2024 11:29

changes

d0d5244

Revert "changes"

720574c

This reverts commit d0d5244.

Reapply "Merge branch 'main' into main"

b087e9e

This reverts commit c114d89.

discard the changes of index.page.tsx file

31da168

discard the changes in index.page.tsx file

10cc2c2

benjagm approved these changes Mar 5, 2024

View reviewed changes

benjagm mentioned this pull request Mar 5, 2024

🐛 Bug: Indentation problems with JsonEditor component #456

Closed

gregsdennis approved these changes Mar 5, 2024

View reviewed changes

benjagm merged commit 316d2a6 into json-schema-org:main Mar 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resolved code formatting issue #371 #385

resolved code formatting issue #371 #385

Adity20 commented Feb 28, 2024 •

edited by benjagm

Loading

gregsdennis Feb 28, 2024

Adity20 commented Feb 29, 2024

Adity20 commented Feb 29, 2024

gregsdennis Mar 1, 2024

gregsdennis Mar 1, 2024

Adity20 Mar 2, 2024

Adity20 Mar 2, 2024

gregsdennis Mar 2, 2024

Adity20 Mar 2, 2024

Adity20 Mar 2, 2024

gregsdennis Mar 2, 2024

Adity20 Mar 2, 2024

gregsdennis Mar 2, 2024

Adity20 commented Mar 2, 2024

gregsdennis commented Mar 2, 2024 •

edited

Loading

Adity20 commented Mar 3, 2024

gregsdennis commented Mar 3, 2024

Adity20 commented Mar 3, 2024

benjagm commented Mar 3, 2024

Adity20 commented Mar 3, 2024 •

edited

Loading

benjagm commented Mar 3, 2024

Adity20 commented Mar 3, 2024

benjagm commented Mar 4, 2024

Adity20 commented Mar 4, 2024

Adity20 commented Mar 5, 2024 •

edited

Loading

gregsdennis commented Mar 5, 2024

benjagm commented Mar 5, 2024

gregsdennis commented Mar 5, 2024

Adity20 commented Mar 5, 2024

benjagm commented Mar 5, 2024

benjagm left a comment

Adity20 commented Mar 5, 2024 •

edited

Loading

benjagm commented Mar 5, 2024

gregsdennis left a comment

+                  <td>
+                    ```json
+                      {

resolved code formatting issue #371 #385

resolved code formatting issue #371 #385

Conversation

Adity20 commented Feb 28, 2024 • edited by benjagm Loading

Choose a reason for hiding this comment

Adity20 commented Feb 29, 2024

Adity20 commented Feb 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Adity20 commented Mar 2, 2024

gregsdennis commented Mar 2, 2024 • edited Loading

Adity20 commented Mar 3, 2024

gregsdennis commented Mar 3, 2024

Adity20 commented Mar 3, 2024

benjagm commented Mar 3, 2024

Adity20 commented Mar 3, 2024 • edited Loading

benjagm commented Mar 3, 2024

Adity20 commented Mar 3, 2024

benjagm commented Mar 4, 2024

Adity20 commented Mar 4, 2024

Adity20 commented Mar 5, 2024 • edited Loading

gregsdennis commented Mar 5, 2024

benjagm commented Mar 5, 2024

gregsdennis commented Mar 5, 2024

Adity20 commented Mar 5, 2024

benjagm commented Mar 5, 2024

benjagm left a comment

Choose a reason for hiding this comment

Adity20 commented Mar 5, 2024 • edited Loading

benjagm commented Mar 5, 2024

gregsdennis left a comment

Choose a reason for hiding this comment

Adity20 commented Feb 28, 2024 •

edited by benjagm

Loading

gregsdennis commented Mar 2, 2024 •

edited

Loading

Adity20 commented Mar 3, 2024 •

edited

Loading

Adity20 commented Mar 5, 2024 •

edited

Loading

Adity20 commented Mar 5, 2024 •

edited

Loading