Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover effects with cursor pointer #1348

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

AQIB-NAWAB
Copy link
Contributor

@AQIB-NAWAB AQIB-NAWAB commented Jan 21, 2025

What kind of change does this PR introduce?
Adding hover effect to sidebar of tools page

Picture
image

Video
Screencast from 2025-01-22 10-32-59.webm

Issue Number:
Closes #1216
#1216

@AQIB-NAWAB AQIB-NAWAB requested a review from a team as a code owner January 21, 2025 13:57
@AQIB-NAWAB
Copy link
Contributor Author

@DhairyaMajmudar I update it and change the description of issues as well

Copy link

github-actions bot commented Jan 21, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview cdd38a4

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ee9538b) to head (cdd38a4).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1348   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is working fine, LGTM 👍🏻

Although @AQIB-NAWAB is requested to follow our PR templates and fill the asked details regarding the PR as here you've not done so.

@AQIB-NAWAB
Copy link
Contributor Author

Thank you for the feedback and for pointing that out. I'll make sure to follow the PR templates and include all the necessary details in future submissions.I updated it. Thanks

@AQIB-NAWAB
Copy link
Contributor Author

Please review the PR

@DhairyaMajmudar DhairyaMajmudar added the ready-to-merge PR that already has two approvals. label Jan 31, 2025
@benjagm benjagm merged commit b7028cc into json-schema-org:main Feb 1, 2025
11 checks passed
Copy link

github-actions bot commented Feb 1, 2025

Congratulations, @AQIB-NAWAB for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge PR that already has two approvals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Adding hovering effects to a filter section will improve the user experince
3 participants