-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle case study #1386
base: main
Are you sure you want to change the base?
Oracle case study #1386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
tags: | ||
- database | ||
- relational | ||
type: Case Study |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be just me, but I think the article goes beyond the typical case study (i.e. here is how company X uses JSON Schema) into actually teaching something to the reader. From that point of view, maybe better to post it on the "Engineering" category?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other side, I think Oracle's case study is indeed very technical, so maybe that's fine. Not sure. @benjagm what do you think?
@@ -0,0 +1,1123 @@ | |||
--- | |||
title: "JSON Schema and Relational Databases: Bridging the Gap!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your title should directly mention Oracle!
{ | ||
"type" : "object", | ||
"o:length" : 1, | ||
"properties" : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing, but can you avoid opening brackets, etc on separate lines in the examples? Just for consistence with other blog posts
I left a few comments, but overall I really like this blog post. Very interesting stuff on directly using JSON Schema for something cool that I think our readers will enjoy. |
What kind of change does this PR introduce?
Adds the Oracle case study to the blog.
Issue Number:
N/A?
Summary
This PR adds the Oracle case study which presents numerous supported JSON Schema capabilities along code examples.
Does this PR introduce a breaking change?
No