Add Table of Contents component to documentation layout #1471
+100
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1471 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DhairyaMajmudar
requested changes
Mar 10, 2025
There was a problem hiding this comment.
@techmannih thanks for PR, pls. have a look to my review comments
Comment on lines
+11
to
+19
| useEffect(() => { | ||
| const mainContent = document.getElementById('main-content'); | ||
| const elements = mainContent | ||
| ? mainContent.querySelectorAll('h1, h2, h3, h4') | ||
| : []; | ||
| const newHeadings: { id: string; text: string; level: number }[] = []; | ||
| elements.forEach((el) => { | ||
| const text = el.textContent || ''; | ||
| if (text.trim().toLowerCase() === 'on this page') return; |
There was a problem hiding this comment.
@techmannih here you're using core javascript, instead use react features to get the same results
Comment on lines
+258
to
+268
| {/* Main Content (Children) */} | ||
| <div | ||
| id='main-content' | ||
| className='col-span-4 md:col-span-2 lg:col-span-2 lg:mt-20 lg:w-5/6 mx-4 md:mx-0' | ||
| > | ||
| {children} | ||
| </div> | ||
|
|
||
| {/* TOC */} | ||
| <div className='sticky top-16 hidden lg:block'> | ||
| <TOC /> |
There was a problem hiding this comment.
Rename the component with much sensible name. Avoid using short forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add Table of Contents component to documentation layout
Issue Number: