-
-
Notifications
You must be signed in to change notification settings - Fork 281
Fixed the horizontal scrollbar issue on the Docs page and adjusted the website's overall scrollbar styling #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1704 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 18 +8
Lines 396 448 +52
Branches 106 116 +10
=========================================
+ Hits 396 448 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these changes in testing file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these changes in this particular file aren't required for this scrollbar issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these changes are made in this file? I think this isn't related with scrollbar issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Deepak-cell311 , the correction you made in components/Sidebar.tsx file and globals.css file are perfect . Good work!
But I think the other changes which you made in other files aren't required for this PR. I have dropped some comments on those files, please update this PR and ping me for the re-review or if you need any help.
Thank You!
What kind of change does this PR introduce?
Bugfix (UI enhancement — scrollbar visibility)
Issue Number:
Screenshots/videos:
Before
After
If relevant, did you update the documentation?
No documentation update was necessary.
Summary
This PR hides the visible scrollbars on the Docs page while maintaining full scroll functionality. This improves the aesthetic appeal of the page, especially when viewed in dark mode, and contributes to a more refined user experience.
Does this PR introduce a breaking change?
NO
Checklist
Please ensure the following tasks are completed before submitting this pull request.