Skip to content

[fix] : Adjusted the Menu DropDown the Navigation Top Bar #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yashwanth1906
Copy link
Contributor

@Yashwanth1906 Yashwanth1906 commented Jun 15, 2025

What kind of change does this PR introduce?

πŸ› Bugfix β€” fixes the scroll lock and layout shift issue when opening the navigation menu on mobile view.

Issue Number:

Closes #1578

Screenshots/videos:

N/A (functional CSS-level fix; visual change is subtle and responsive)

If relevant, did you update the documentation?

Not applicable β€” no changes required to documentation.

Summary

This PR resolves the issue when the top bar is menu is opened in mobile dimension the content of the page is getting hidden.
More Detail Issue Description: #1578.

Fix implemented:

  1. In the components/Layout.tsx , I have wrapped the component inside a div and applied some css changes in it.
  2. And also in the useEffect hook added the body.style.overflow logic according to whether it is in mobile dimension.

Does this PR introduce a breaking change?

No breaking changes β€” the fix is isolated to the responsive mobile layout.

@Yashwanth1906 Yashwanth1906 requested a review from a team as a code owner June 15, 2025 09:11
Copy link

Hi @Yashwanth1906! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

Hi @Yashwanth1906! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

github-actions bot commented Jun 15, 2025

built with Refined Cloudflare Pages Action

⚑ Cloudflare Pages Deployment

Name Status Preview Last Commit
website βœ… Ready (View Log) Visit Preview 22800e5

Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 100.00%. Comparing base (1ac0817) to head (22800e5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1712   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          448       448           
  Branches       116       116           
=========================================
  Hits           448       448           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Yashwanth1906
Copy link
Contributor Author

@benjagm @idanidan29 Can u review this PR?

@Yashwanth1906
Copy link
Contributor Author

@Utkarsh-123github Can I know what is unclear in this PR? So that I can make changes accordingly..

@Utkarsh-123github
Copy link
Member

Utkarsh-123github commented Jun 19, 2025

Hey @Yashwanth1906 , this PR is completely fine, actually I was adding the PRs to the PR board, so for the initial step I need to add all the PRs to unclear stage and then to Ready to review status. I'll make the changes by the EOD.

@Utkarsh-123github Utkarsh-123github moved this from Unclear to Ready to review in PR - Triage Group Jun 19, 2025
@Yashwanth1906
Copy link
Contributor Author

@Utkarsh-123github Okay fine.

@Utkarsh-123github
Copy link
Member

Hi @Yashwanth1906 , I observed that you have raised 2 different PRs for the same issue. Could you please close one of the PR which is outdated, so that PR reviewing could be easier and duplication is avoided.
This is the other PR which I am talking about : #1518

@Yashwanth1906
Copy link
Contributor Author

@Utkarsh-123github This PR is about fixing the top bar issue #1578 . and the #1518 is about fixing the sidebar toggle. Both are different issues.

@Utkarsh-123github
Copy link
Member

Utkarsh-123github commented Jun 28, 2025

@Yashwanth1906 but you have mentioned in both the PR description the same issue #1484 . I guess you have tagged the wrong issue, kindly update the PR description.

Copy link

Hi @Yashwanth1906! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

1 similar comment
Copy link

Hi @Yashwanth1906! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@Yashwanth1906
Copy link
Contributor Author

@Utkarsh-123github I have updated the PR description. Btw, sry for the wrong pr description.

@Utkarsh-123github
Copy link
Member

No worries at all, thanks for fixing it! πŸ™Œ

@Utkarsh-123github
Copy link
Member

Hey @Yashwanth1906 , you've done a great job !
But I have observed a bug here in your PR, please refer to this video in which I have described about it and try to fix it.
Thank You!

2025-06-28.13-31-00.mp4

Copy link
Member

@Utkarsh-123github Utkarsh-123github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the attached video and try to fix it. Thank you!

@Utkarsh-123github Utkarsh-123github moved this from Ready to review to Changes requested in PR - Triage Group Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Changes requested
Development

Successfully merging this pull request may close these issues.

πŸ› Bug: In mobile, Nav bar is hiding the content of the page.
2 participants