-
-
Notifications
You must be signed in to change notification settings - Fork 281
[fix] : Adjusted the Menu DropDown the Navigation Top Bar #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[fix] : Adjusted the Menu DropDown the Navigation Top Bar #1712
Conversation
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Actionβ‘ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 448 448
Branches 116 116
=========================================
Hits 448 448 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
@benjagm @idanidan29 Can u review this PR? |
@Utkarsh-123github Can I know what is unclear in this PR? So that I can make changes accordingly.. |
Hey @Yashwanth1906 , this PR is completely fine, actually I was adding the PRs to the PR board, so for the initial step I need to add all the PRs to unclear stage and then to Ready to review status. I'll make the changes by the EOD. |
@Utkarsh-123github Okay fine. |
Hi @Yashwanth1906 , I observed that you have raised 2 different PRs for the same issue. Could you please close one of the PR which is outdated, so that PR reviewing could be easier and duplication is avoided. |
@Utkarsh-123github This PR is about fixing the top bar issue #1578 . and the #1518 is about fixing the sidebar toggle. Both are different issues. |
@Yashwanth1906 but you have mentioned in both the PR description the same issue #1484 . I guess you have tagged the wrong issue, kindly update the PR description. |
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
1 similar comment
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
@Utkarsh-123github I have updated the PR description. Btw, sry for the wrong pr description. |
No worries at all, thanks for fixing it! π |
Hey @Yashwanth1906 , you've done a great job ! 2025-06-28.13-31-00.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to the attached video and try to fix it. Thank you!
What kind of change does this PR introduce?
π Bugfix β fixes the scroll lock and layout shift issue when opening the navigation menu on mobile view.
Issue Number:
Closes #1578
Screenshots/videos:
N/A (functional CSS-level fix; visual change is subtle and responsive)
If relevant, did you update the documentation?
Not applicable β no changes required to documentation.
Summary
This PR resolves the issue when the top bar is menu is opened in mobile dimension the content of the page is getting hidden.
More Detail Issue Description: #1578.
Fix implemented:
Does this PR introduce a breaking change?
No breaking changes β the fix is isolated to the responsive mobile layout.