Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(numeric): fix wrong sample #256

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix(numeric): fix wrong sample #256

merged 1 commit into from
Dec 5, 2023

Conversation

vm-001
Copy link
Contributor

@vm-001 vm-001 commented Dec 5, 2023 •
edited
Loading

GitHub Issue: # / NA

Summary:

Change valid to false, as the title said, "Numbers as strings are rejected"

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

Yes/No
[JUSTIFICATION]

jdesrosiers
jdesrosiers approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this error and for making the time to submit a fix!

@jdesrosiers jdesrosiers merged commit e29a4b8 into json-schema-org:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdesrosiers jdesrosiers jdesrosiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vm-001 @jdesrosiers