Feat: Adding query string to blog tags. #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjagm
requested changes
Jun 4, 2024
There was a problem hiding this comment.
It works but I found something with the All button which basically removes the filter. When the user clicks "All" you are applying this queryparameter "?type=All" but I think it will be a better solution to remove completely the type queryparameter from the url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
While clicking the tags in the blog page the query string will be updated by blog's category.
Issue Number:
Screenshots/videos:
Summary
Query string added to tags.
Does this PR introduce a breaking change?
N/A