Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miscellaneous-examples.md #832

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

albinstman
Copy link
Contributor

Summary

Update faulty description for example

Does this PR introduce a breaking change?

No

Update faulty description
@albinstman albinstman requested a review from a team as a code owner July 28, 2024 12:15
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for opening this PR @albinstman !! I just left a small suggestion.

pages/learn/miscellaneous-examples.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for fixing this @albinstman !!

@benjagm benjagm merged commit 4164058 into json-schema-org:main Aug 13, 2024
6 of 7 checks passed
Copy link

Congratulations, @albinstman for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants