-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PHP 8.4 deprecation warnings in 6.x #761
base: 6.0.x
Are you sure you want to change the base?
Conversation
Fixes all issues that emits a deprecation notice on PHP 8.4. See: - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types) - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
Hi @W0rma Thanks for the contribution. I was curious why you're targeting the The changes (besides the one in Also if you think the changes in |
@DannyvdSluijs Will the next release be a major ( I wasn't sure if |
@W0rma Im currently to only developer pushing this project forward. Im included to work towards a |
I'm happy to assist as far as I can. Could you create a |
Ideally we get @Seldaek to rename the current This would also help #776 move forward for other people. |
@DannyvdSluijs For what it's worth, in my opinion you should be set as a project owner. You're the main person driving this library forward, and frankly the only trusted party who has time. And you're clearly in it for the long haul; you've been working on this for quite some time now. It's been wonderful to see some progress 😁 @Seldaek What do you think? I reckon giving @DannyvdSluijs those permissions seems reasonable. |
Yeah that makes total sense. I've granted you owner access on the organization @DannyvdSluijs :) |
@W0rma if you could revert the changes is |
@DannyvdSluijs Sure, I can do that. Just to make sure that there is no misunderstanding: The version bump is necessary because nullable types require at least PHP 7.1 (see https://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.nullable-types). Do you plan to add the change again after this PR is merged? |
From #726 (reply in thread):
This PR uses a similar strategy as in #731 but for 6.x: