Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minify html and various improvements #48

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

SethFalco
Copy link
Member

@SethFalco SethFalco commented Dec 4, 2023

A general revamp of the theme.

  • Minify the HTML before writing to a file.
  • Add the html[lang] attribute to the document, and expect language codes in the languages section instead of language names.
  • When displaying languages, use the JavaScript Intl API instead of accepting literal strings.
  • When displaying links, only display the domain rather than the whole URL. i.e. https://example.org/ → example.org
  • For the Twitter card logic, also accept a social media network named "x".
  • Clean up CSS and remove the standard reset in favor of our own.
  • Remove unused classes from the Handlebars template.
  • Updates font-family to include more fonts across operating systems.

Chores

  • Include a JSON Resume fixture that can be used for test builds and the preview.
  • Add GitHub action to test build before merging PRs. (Currently just runs build:* rather than unit tests.)
  • Fix a typo in the README.

@SethFalco SethFalco merged commit ec0bb0e into jsonresume:main Dec 4, 2023
1 check passed
@SethFalco SethFalco deleted the minify branch December 4, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant