fix(theme-stackoverflow): add missing empty space after "position" on… #145

levino · 2024-09-06T07:26:07Z

… print outs

Before:

After:

Summary by CodeRabbit

Style
- Adjusted the styling of printouts for improved visual consistency by adding missing empty spaces.
Chores
- Updated the dependency resolution for jsonresume-theme-tailwind to link it to the workspace.

… print outs

changeset-bot · 2024-09-06T07:26:11Z

🦋 Changeset detected

Latest commit: 519b1d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@jsonresume/theme-stackoverflow	Patch
homepage2	Patch
registry	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-09-06T07:26:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jsonresume-org-homepage2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 12, 2024 0:27am
jsonresume-org-registry	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 12, 2024 0:27am

coderabbitai · 2024-09-06T07:26:15Z

Walkthrough

The changes introduce a patch to the @jsonresume/theme-stackoverflow package, specifically addressing the formatting of printouts by adding missing empty space in certain positions. Additionally, the package.json file for the registry application is modified to update the dependency for jsonresume-theme-tailwind from a wildcard version to a workspace reference. These adjustments ensure better formatting and dependency resolution within the project.

Changes

File Path	Change Summary
.changeset/stale-snails-search.md	Added a patch to `@jsonresume/theme-stackoverflow` for improved printout formatting by adding missing spaces.
apps/registry/package.json	Changed `jsonresume-theme-tailwind` dependency from `""` to `"workspace:"`.

Poem

🐰 In the garden where I bound and leap,
A patch was made, a promise to keep!
Spaces added, oh what a sight,
Formatting shines, all feels right.
With dependencies snug and tight,
We hop along, hearts full of light! 🌸

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

alwaysmeticulous · 2024-09-06T07:28:35Z

🤖 No test run has been triggered as your Meticulous project has been deactivated (since you haven't viewed any test results in a while). Click here to reactivate.

_{Last updated for commit 519b1d8. This comment will update as new commits are pushed.}

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 40b46fe and 7f22ea2.

Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing (1)

themes/stackoverflow/style.css (1 hunks)

Files skipped from review due to trivial changes (1)

themes/stackoverflow/style.css

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7f22ea2 and 39456b3.

Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing (3)

apps/registry/package.json (1 hunks)
packages/eslint-config-custom/package.json (1 hunks)
themes/stackoverflow/package.json (2 hunks)

Files skipped from review due to trivial changes (1)

apps/registry/package.json

Additional comments not posted (3)

packages/eslint-config-custom/package.json (1)

9-9: Approve the dependency update but verify compatibility.

The update from "eslint-config-turbo": "^1" to "eslint-config-turbo": "^2" is approved. However, it's crucial to ensure that this major version update is compatible with the rest of the project's ESLint configuration.

Run the following script to check for ESLint configuration files that might need updates:

themes/stackoverflow/package.json (2)

46-52: Approve the Storybook and i18next updates but verify compatibility.

The updates to Storybook packages and storybook-react-i18next from ^2.0.1 to ^3 are approved. However, it's crucial to ensure that these updates are compatible with the existing project setup and do not introduce any breaking changes.

Run the following script to check for Storybook configuration files that might need updates:

Also applies to: 68-69

45-45: Approve the ESLint dependency change but verify linting rules.

The replacement of @repo/eslint-config-custom with a direct dependency on eslint is approved. However, verify that the linting rules and configurations are correctly updated to reflect this change.

Run the following script to check for ESLint rule files that might need updates:

Also applies to: 65-65

s3rj1k · 2024-11-01T16:01:32Z

Closes #155

thomasdavis

lgtm

levino · 2024-11-12T10:46:27Z

I do not remember how this will be released. Are there docs on the process?

thomasdavis · 2024-11-12T11:37:06Z

The registry is importing stackoverflow theme from the workspace, so after it is merged, vercel will just build and deploy the registry which will use the latest/relative files of the theme.

But you could also bump the minor in the stackoverflow theme and npm publish (unless you have an action for it already, which you may have did)

levino · 2024-11-12T11:38:38Z

Lets hold on to this for a moment and add a changeset. This could trigger the release, will double check.

thomasdavis · 2024-11-12T11:43:25Z

I just pushed something straight to master, I will go back to putting up PR's

levino · 2024-11-12T11:45:31Z

I added the changeset which should trigger the release flow once this PR is merged by opening a release PR.

However the PR here cannot be merged because you disabled the test script and it is still required status check. Do you want to bring back the test script or do you want to remove it as a required check?

levino · 2024-11-12T11:48:37Z

packages/eslint-config-custom/package.json

@@ -6,7 +6,7 @@
  "license": "MIT",
  "dependencies": {
    "eslint-config-prettier": "^8.3.0",
-    "eslint-config-turbo": "^1",
+    "eslint-config-turbo": "^2",


Not sure about this one. Should probably not be part of the PR.

Seems to be important. Idk why. Maybe because the turbo version got updated or so.

thomasdavis · 2024-11-12T11:50:05Z

I'm on for a couple hours tonight, happy to bring back the test command, but it was broken, I will set up a branch to see if I can get it working right now.

levino · 2024-11-12T11:53:22Z

I'm on for a couple hours tonight, happy to bring back the test command, but it was broken, I will set up a branch to see if I can get it working right now.

IIRC it used to work for a while until certain changes were made to the codebase. If after such changes a test script does not work any more, either the new code is broken or the test script needs to be adapted. If the test script stopped working also on old commits on which it used to pass, that would be another story.

fix(theme-stackoverflow): add missing empty space after "position" on…

7f22ea2

… print outs

vercel bot deployed to Preview – jsonresume-org-registry September 6, 2024 07:27 View deployment

vercel bot deployed to Preview – jsonresume-org-homepage2 September 6, 2024 07:28 View deployment

coderabbitai bot reviewed Sep 6, 2024

View reviewed changes

chore(theme-stackoverflow): reenable dev build

39456b3

vercel bot deployed to Preview – jsonresume-org-homepage2 September 6, 2024 07:45 View deployment

vercel bot deployed to Preview – jsonresume-org-registry September 6, 2024 07:48 View deployment

coderabbitai bot reviewed Sep 6, 2024

View reviewed changes

levino enabled auto-merge September 6, 2024 07:49

levino mentioned this pull request Sep 12, 2024

running turbo dev fails #146

Open

levino mentioned this pull request Nov 1, 2024

Theme stackoverflow print view quirk #155

Closed

thomasdavis reviewed Nov 12, 2024

View reviewed changes

thomasdavis approved these changes Nov 12, 2024

View reviewed changes

Merge branch 'master' into fix-styles

07c1d48

vercel bot deployed to Preview – jsonresume-org-registry November 12, 2024 10:45 View deployment

vercel bot deployed to Preview – jsonresume-org-homepage2 November 12, 2024 10:47 View deployment

levino disabled auto-merge November 12, 2024 11:38

levino added 2 commits November 12, 2024 11:40

Merge remote-tracking branch 'origin/master' into fix-styles

e02c7b5

add changeset for latest changes

f18f64c

levino enabled auto-merge November 12, 2024 11:45

vercel bot deployed to Preview – jsonresume-org-registry November 12, 2024 11:47 View deployment

Merge remote-tracking branch 'origin/master' into fix-styles

8970e79

levino commented Nov 12, 2024

View reviewed changes

vercel bot deployed to Preview – jsonresume-org-homepage2 November 12, 2024 11:49 View deployment

vercel bot deployed to Preview – jsonresume-org-registry November 12, 2024 11:51 View deployment

coderabbitai bot approved these changes Nov 12, 2024

View reviewed changes

Merge branch 'master' into fix-styles

519b1d8

vercel bot deployed to Preview – jsonresume-org-registry November 12, 2024 12:26 View deployment

levino merged commit 91e8091 into master Nov 12, 2024
6 of 7 checks passed

levino deleted the fix-styles branch November 12, 2024 12:27

vercel bot deployed to Preview – jsonresume-org-homepage2 November 12, 2024 12:27 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(theme-stackoverflow): add missing empty space after "position" on… #145

fix(theme-stackoverflow): add missing empty space after "position" on… #145

levino commented Sep 6, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Sep 6, 2024 •

edited

Loading

vercel bot commented Sep 6, 2024 •

edited

Loading

coderabbitai bot commented Sep 6, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

alwaysmeticulous bot commented Sep 6, 2024 •

edited

Loading

coderabbitai bot left a comment

coderabbitai bot left a comment

s3rj1k commented Nov 1, 2024 •

edited by levino

Loading

thomasdavis left a comment

levino commented Nov 12, 2024

thomasdavis commented Nov 12, 2024

levino commented Nov 12, 2024

thomasdavis commented Nov 12, 2024

levino commented Nov 12, 2024 •

edited

Loading

levino Nov 12, 2024

levino Nov 12, 2024

thomasdavis commented Nov 12, 2024

levino commented Nov 12, 2024

fix(theme-stackoverflow): add missing empty space after "position" on… #145

fix(theme-stackoverflow): add missing empty space after "position" on… #145

Conversation

levino commented Sep 6, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

Summary by CodeRabbit

changeset-bot bot commented Sep 6, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Sep 6, 2024 • edited Loading

coderabbitai bot commented Sep 6, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

alwaysmeticulous bot commented Sep 6, 2024 • edited Loading

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

s3rj1k commented Nov 1, 2024 • edited by levino Loading

thomasdavis left a comment

Choose a reason for hiding this comment

levino commented Nov 12, 2024

thomasdavis commented Nov 12, 2024

levino commented Nov 12, 2024

thomasdavis commented Nov 12, 2024

levino commented Nov 12, 2024 • edited Loading

levino Nov 12, 2024

Choose a reason for hiding this comment

levino Nov 12, 2024

Choose a reason for hiding this comment

thomasdavis commented Nov 12, 2024

levino commented Nov 12, 2024

levino commented Sep 6, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Sep 6, 2024 •

edited

Loading

vercel bot commented Sep 6, 2024 •

edited

Loading

coderabbitai bot commented Sep 6, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

alwaysmeticulous bot commented Sep 6, 2024 •

edited

Loading

s3rj1k commented Nov 1, 2024 •

edited by levino

Loading

levino commented Nov 12, 2024 •

edited

Loading