Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): build apps in ci #19

Merged
merged 2 commits into from
Nov 24, 2023
Merged

feat(ci): build apps in ci #19

merged 2 commits into from
Nov 24, 2023

Conversation

levino
Copy link
Collaborator

@levino levino commented Nov 24, 2023

Summary by CodeRabbit

  • New Features

    • Introduced a new linting process to ensure code quality.
    • Updated the build process to support Ruby, enhancing the build system's capabilities.
  • Chores

    • Updated the Ruby version to 3.1.4 for compatibility and performance improvements.
    • Improved the repository by ignoring vendor and site directories to keep the workspace clean.

Copy link
Contributor

coderabbitai bot commented Nov 24, 2023

Walkthrough

The project has introduced a new linting job within its CI pipeline, ensuring code quality through automated checks. It also updated the Ruby version and made changes to the build process, including dependency management with pnpm and bundle. Additionally, updates to the .gitignore file suggest a focus on Ruby-based projects, ignoring common directories generated by such environments.

Changes

File Path Change Summary
.github/workflows/ci.yml Added lint job, environment variables, and updated build job with Ruby setup and dependency installation
.ruby-version Updated to version 3.1.4
apps/homepage/.gitignore Added vendor and _site directories to ignore list

Poem

In the land of code where the green tests run,
A rabbit hopped in, its job just begun.
🐇 With a flick of its ear, a new lint job's here,
Ensuring the code is clean and clear.

Ruby shines bright, version point four,
While vendor and _site are shown the door.
🚪 In workflows and builds, it's a fresh start,
With pnpm and bundle, it's a crafty art.

So here's to the changes, may they compile,
For every line of code, let it bring a smile.
🎉 With each push and pull, let's all take part,
In this digital canvas, where code's a heart.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 9:25am
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 9:25am

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9c80b6e and e54d53f.
Files ignored due to filter (5)
  • apps/homepage/Gemfile.lock
  • apps/homepage/_config.yml
  • apps/homepage/package.json
  • pnpm-lock.yaml
  • turbo.json
Files selected for processing (3)
  • .github/workflows/ci.yml (1 hunks)
  • .ruby-version (1 hunks)
  • apps/homepage/.gitignore (1 hunks)
Files skipped from review due to trivial changes (2)
  • .ruby-version
  • apps/homepage/.gitignore

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9c80b6e and 71fc18e.
Files ignored due to filter (5)
  • apps/homepage/Gemfile.lock
  • apps/homepage/_config.yml
  • apps/homepage/package.json
  • pnpm-lock.yaml
  • turbo.json
Files selected for processing (3)
  • .github/workflows/ci.yml (1 hunks)
  • .ruby-version (1 hunks)
  • apps/homepage/.gitignore (1 hunks)
Files skipped from review due to trivial changes (2)
  • .ruby-version
  • apps/homepage/.gitignore
Additional comments: 3
.github/workflows/ci.yml (3)
  • 6-11:
    Ensure that the TURBO_TEAM variable is correctly set up in the GitHub repository secrets or environment variables, as it uses vars instead of secrets which might be a typo or a custom implementation.

  • 28-28:
    The linting command pnpm turbo lint prettier seems to combine multiple actions. Verify that turbo is a valid pnpm command and that it is configured to run both linting and prettier formatting as intended.

  • 46-47:
    The bundle install command is run without specifying the Ruby version. Ensure that the Ruby version used matches the one specified in the .ruby-version file to avoid version mismatches.

@levino levino removed this pull request from the merge queue due to a manual request Nov 24, 2023
@levino levino added this pull request to the merge queue Nov 24, 2023
Merged via the queue into master with commit b9c862d Nov 24, 2023
3 checks passed
@levino levino deleted the feature/build-in-ci branch November 24, 2023 09:33
levino added a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant