-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): build apps in ci #19
Conversation
WalkthroughThe project has introduced a new linting job within its CI pipeline, ensuring code quality through automated checks. It also updated the Ruby version and made changes to the build process, including dependency management with Changes
Poem
TipsChat with CodeRabbit Bot (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (5)
- apps/homepage/Gemfile.lock
- apps/homepage/_config.yml
- apps/homepage/package.json
- pnpm-lock.yaml
- turbo.json
Files selected for processing (3)
- .github/workflows/ci.yml (1 hunks)
- .ruby-version (1 hunks)
- apps/homepage/.gitignore (1 hunks)
Files skipped from review due to trivial changes (2)
- .ruby-version
- apps/homepage/.gitignore
e54d53f
to
71fc18e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (5)
- apps/homepage/Gemfile.lock
- apps/homepage/_config.yml
- apps/homepage/package.json
- pnpm-lock.yaml
- turbo.json
Files selected for processing (3)
- .github/workflows/ci.yml (1 hunks)
- .ruby-version (1 hunks)
- apps/homepage/.gitignore (1 hunks)
Files skipped from review due to trivial changes (2)
- .ruby-version
- apps/homepage/.gitignore
Additional comments: 3
.github/workflows/ci.yml (3)
6-11:
Ensure that theTURBO_TEAM
variable is correctly set up in the GitHub repository secrets or environment variables, as it usesvars
instead ofsecrets
which might be a typo or a custom implementation.28-28:
The linting commandpnpm turbo lint prettier
seems to combine multiple actions. Verify thatturbo
is a valid pnpm command and that it is configured to run both linting and prettier formatting as intended.46-47:
Thebundle install
command is run without specifying the Ruby version. Ensure that the Ruby version used matches the one specified in the.ruby-version
file to avoid version mismatches.
Summary by CodeRabbit
New Features
Chores