Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add theme stackoverflow #32

Merged
merged 159 commits into from
Dec 14, 2023

Conversation

levino
Copy link
Collaborator

@levino levino commented Nov 28, 2023

No description provided.

Francesco Esposito and others added 30 commits September 7, 2015 17:07
add support to manage birth data
Fixes typo for interests' summary
Since word breaks are not shown with a hyphen, this behaviour leads to a
sloppy-looking CV.
Prevent word breaks in very long lines
levino and others added 21 commits May 2, 2023 12:24
…mponents--mock-jwks

chore(main): release 1.0.0
actually this is more a chore, but I need to produce a new release so fix
Release-As: 2.0.5
…mponents--mock-jwks

chore(main): release 2.0.5
fix(docs): link to example deployment
feat: support keywords for work experience entries
…mponents--mock-jwks

chore(main): release 2.1.0
Copy link
Contributor

coderabbitai bot commented Nov 28, 2023

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 8:33am
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 8:33am

@levino
Copy link
Collaborator Author

levino commented Nov 28, 2023

I am kinda trying something out here. I locally rewrote the history of my fork of the stackoverflow theme with:

git filter-repo --to-subdirectory-filter themes/stackoverflow --tag-rename '':'@jsonresume/theme-stackoverflow'

then I added the local folder as a remote for jsonresume

git remote add stackoverflow-theme /tmp/jsonresume-theme-stackoverflow-react

and merged it by allowing an unrelated history.

git merge --allow-unrelated-histories stackoverflow-theme/main

So this way we can nicely "import" third party repositories into the codebase of the monorepo while even keeping the history (and the attribution to maintainers / creators etc.). I personally would embrace if my code was stored here as long as someone allows me to update it etc. and publishes it safely and securely.

The question is: Will people approve of this approach? For example @phoinixi. What do you think @phoinixi? Would you be offended if we merged this and then published the code as @jsonresume/theme-stackoverflow? I think @thomasdavis would always approve your PRs to the code, maybe even make you a collaborator etc. However: How do you feel?

And what about resumed? If we decided to make resumed the new official @jsonresume/cli, would you, @rbardini be okay with that? Please let me know your opinion.

@thomasdavis
Copy link
Member

If the original authors would be up it with, there would be credit given in multiple places and collaborator access should be generally fine.

It would help us get to a more symbiotic ecosystem more quickly when it comes to things like themes/stackoverflow/src/dateHelpers.tsx and i18n utils.

When bumping schema changes, we could more easily update all of the "official" themes in a foul swoop also.

@github-merge-queue github-merge-queue bot merged commit 37106bc into master Dec 14, 2023
5 of 6 checks passed
@levino levino deleted the feature/add-theme-stackoverflow branch December 14, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.