Add AudioPlayer class that handles both WebAudio and HTML5 audio #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bbaddbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…e plugins using AudioPlayer and added tests; changed test-utils' clickTarget to respect disabled forms
Completing the implementation of the AudioPlayer class in JsPsych
…for enable_button_after for audio_button_response.
Updates to the AudioPlayer class and audio-button-response plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #341 by creating an
AudioPlayerclass to handle the basic audio functions (load, play, stop, event handling) required by most uses of audio in jsPsych.This will allow us to clean up the code in the audio plugins to avoid checking whether the audio engine is HTML5 or web audio.
Remaining tasks include:
AudioPlayer