-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set up readme to update automatically upon publish of new plugins/ext… #133
Conversation
|
|
||
- name: Update README list of plugins and extensions | ||
run: npm run update-readme.js | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add the commit and push actions here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly dropping a note here that we can just make the changesets action do the commit work for us:
"update-unpkg-links": "gulp updateUnpkgLinks",
+ "update-readme": "node update-readme.js",
"prepare": "husky install",
"changeset": "changeset",
- "changeset:version": "changeset version && npm install && npm run update-unpkg-links",
+ "changeset:version": "changeset version && npm install && npm run update-unpkg-links && npm run update-readme",
@@ -28,6 +28,7 @@ | |||
"directory": "packages/extension-countdown" | |||
}, | |||
"author": "Shaobin Jiang", | |||
"authorGitHub": "https://github.com/Shaobin-Jiang", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make this compliant with how npm expects it:
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#people-fields-author-contributors
…ensions