Building nback #23
Building nback #23
Conversation
🦋 Changeset detectedLatest commit: 14095fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/n-back/dist/index.global.js
Outdated
There was a problem hiding this comment.
not sure why but the dist files are still in the repo- make sure to remove them and try running npm run build again, if they show up again, there may be a problem in the root .gitignore file
There was a problem hiding this comment.
I think the .gitignore file included that. Checking what's wrong
packages/n-back/README.md
Outdated
|
|
||
| ## Compatibility | ||
|
|
||
| `@jspsych-timelines/n-back` requires jsPsych v7.0.0 or later. |
There was a problem hiding this comment.
would it be possible to turn this timeline into supporting v8 immediately?
There was a problem hiding this comment.
I think I didn't use any functions that were affected by the change from v7 to v8, so I'll probably just update the README
packages/n-back/src/index.ts
Outdated
| choices: "NO_KEYS", | ||
| on_start: function () { | ||
| if (data_output == "csv"){ | ||
| jsPsych.data.get().localSave('csv', `n_back.csv`);} else if (data_output == "json") { |
There was a problem hiding this comment.
just wondering, is it normal to .localSave(), or can we give the developer the option to locally save or not?
No description provided.