Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstzd): Implement health check for OctezNode #566

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

huancheng-trili
Copy link
Collaborator

@huancheng-trili huancheng-trili commented Sep 17, 2024

Context

Part of JSTZ-116.

JSTZ-116

Description

Implement health check for OctezNode.

Manually testing the PR

  • Integration test: ran the code in the file octez_node_test.rs and everything worked as expected.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 37.29%. Comparing base (a737e1f) to head (c8b9df6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstzd/src/task/octez_node.rs 77.77% 4 Missing ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/task/octez_node.rs 88.27% <77.77%> (+1.25%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a737e1f...c8b9df6. Read the comment docs.

@huancheng-trili huancheng-trili changed the base branch from huan/jstzd-impl-octez-node to huan/jstzd-impl-octez-node-1 September 18, 2024 11:52
@huancheng-trili huancheng-trili force-pushed the huan/jstzd-impl-octez-node-2 branch 2 times, most recently from 93c05c8 to 46e814b Compare September 24, 2024 12:42
@huancheng-trili huancheng-trili force-pushed the huan/jstzd-impl-octez-node-2 branch 3 times, most recently from b3e7566 to 249e580 Compare September 24, 2024 13:41
@huancheng-trili huancheng-trili force-pushed the huan/jstzd-impl-octez-node-2 branch 2 times, most recently from 8d41689 to b003b72 Compare September 25, 2024 14:49
@huancheng-trili huancheng-trili marked this pull request as ready for review September 25, 2024 14:53
@huancheng-trili huancheng-trili force-pushed the huan/jstzd-impl-octez-node-1 branch 2 times, most recently from d1a7135 to f041aab Compare September 27, 2024 08:38
@huancheng-trili huancheng-trili force-pushed the huan/jstzd-impl-octez-node-1 branch 2 times, most recently from a7cea9f to 6c77a12 Compare October 2, 2024 13:29
Base automatically changed from huan/jstzd-impl-octez-node-1 to main October 2, 2024 13:40
@huancheng-trili huancheng-trili merged commit e1933c8 into main Oct 2, 2024
3 checks passed
@huancheng-trili huancheng-trili deleted the huan/jstzd-impl-octez-node-2 branch October 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants