Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstzd): add config init for client #577

Merged
merged 1 commit into from
Oct 1, 2024
Merged

feat(jstzd): add config init for client #577

merged 1 commit into from
Oct 1, 2024

Conversation

ryutamago
Copy link
Collaborator

@ryutamago ryutamago commented Sep 27, 2024

Context

141

blocked by #572

Description

This PR implements the octez_client config init
In order to be consistent with the api for #582 i return the Child and let the user handle it.
Note: i omitted the following two argumetns as this is only used for mockup mode

--bootstrap-accounts 
--protocol-constants

Manually testing the PR

two integration test:

cargo test --package jstzd --test octez_client_test         

output:

running 2 tests
test command_fails_on_non_utf8_path ... ok
test config_init ... ok

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 37.36%. Comparing base (5fb136e) to head (faa2ddb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstzd/src/task/octez_client.rs 66.66% 0 Missing and 3 partials ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/task/octez_client.rs 88.65% <66.66%> (+3.79%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb136e...faa2ddb. Read the comment docs.

@ryutamago ryutamago force-pushed the leo-config-init branch 2 times, most recently from 861d51a to c9705d2 Compare September 30, 2024 15:06
@ryutamago ryutamago mentioned this pull request Sep 30, 2024
@ryutamago ryutamago changed the base branch from leo-jstzd-126 to leo-client-command September 30, 2024 15:18
@ryutamago ryutamago force-pushed the leo-config-init branch 2 times, most recently from bfc415d to 08aa53e Compare September 30, 2024 15:22
Copy link
Collaborator

@huancheng-trili huancheng-trili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

crates/jstzd/src/task/octez_client.rs Outdated Show resolved Hide resolved
crates/jstzd/src/task/octez_client.rs Outdated Show resolved Hide resolved
Base automatically changed from leo-client-command to main October 1, 2024 12:54
@ryutamago ryutamago force-pushed the leo-config-init branch 2 times, most recently from 0a11a51 to 61de29a Compare October 1, 2024 13:07
@ryutamago ryutamago merged commit 9c4c510 into main Oct 1, 2024
5 checks passed
@ryutamago ryutamago deleted the leo-config-init branch October 1, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants