Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octez client: show address #591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

octez client: show address #591

wants to merge 1 commit into from

Conversation

ryutamago
Copy link
Collaborator

@ryutamago ryutamago commented Oct 7, 2024

Context

show url

Description

Show the address for the given alias.
Implemented an Address struct that can be parsed from the stdout of the show address command

Manually testing the PR

Added 3 integration tests

cargo test --package jstzd --test octez_client_test -- show_address

running 3 tests
test show_address_fails_for_non_existing_alias ... ok
test show_address_with_secret_key ... ok
test show_address ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 6 filtered out; finished in 1.26s

4 unit tests:

cargo test --package jstzd --lib -- task::octez_client::test::address_try_from

running 4 tests
test task::octez_client::test::address_try_from_fails_on_invalid_input ... ok
test task::octez_client::test::address_try_from_fails_on_invalid_key ... ok
test task::octez_client::test::address_try_from_fails_on_missing_public_key ... ok
test task::octez_client::test::address_try_from ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 21 filtered out; finished in 0.00s

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 91.04478% with 6 lines in your changes missing coverage. Please review.

Project coverage is 37.75%. Comparing base (f48a8d1) to head (da7cf4d).

Files with missing lines Patch % Lines
crates/jstzd/src/task/octez_client.rs 91.04% 1 Missing and 5 partials ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/task/octez_client.rs 88.81% <91.04%> (+0.63%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48a8d1...da7cf4d. Read the comment docs.

@ryutamago ryutamago marked this pull request as ready for review October 8, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants