Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli: Responses #81

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Cli: Responses #81

merged 1 commit into from
Oct 31, 2023

Conversation

johnyob
Copy link
Collaborator

@johnyob johnyob commented Oct 27, 2023

Context

Related Tasks: Reading response from durable storage on smart function call

Description

Dependencies: #64, #77, #66

This PR permits CLI users to read the responses to signed operations (e.g. run or deploy)
in their terminal without tailing the kernel.log file.

Manually testing the PR

cargo run --bin jstz -- deploy index.js
// expected output will contain address of the smart function just deployed
addr=tz4...
cargo run --bin jstz -- run "tezos://$addr/"
// expected output will contain response from running the smart function

@johnyob johnyob changed the base branch from main to ajob410@node/responses October 27, 2023 11:51
alanmarkoTrilitech
alanmarkoTrilitech reviewed Oct 27, 2023
View reviewed changes
jstz_cli/src/node.rs Outdated Show resolved Hide resolved
jstz_cli/src/node.rs Outdated Show resolved Hide resolved
@johnyob johnyob force-pushed the ajob410@node/responses branch 2 times, most recently from 2e375c7 to 67ad895 Compare October 30, 2023 16:41
@johnyob johnyob force-pushed the ajob410@cli/responses branch 2 times, most recently from bb851df to 83cc964 Compare October 30, 2023 16:48
Base automatically changed from ajob410@node/responses to main October 31, 2023 11:27
@johnyob
Copy link
Collaborator Author

johnyob commented Oct 31, 2023

@alanmarkoTrilitech bump for approval

alanmarkoTrilitech
alanmarkoTrilitech approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@alanmarkoTrilitech alanmarkoTrilitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnyob johnyob merged commit 3ffc0a9 into main Oct 31, 2023
5 checks passed
@johnyob johnyob deleted the ajob410@cli/responses branch October 31, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmarkoTrilitech alanmarkoTrilitech alanmarkoTrilitech approved these changes

Assignees
No one assigned
Labels
jstz::cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnyob @alanmarkoTrilitech