Api: URL Pattern API implementation #92
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: 🚧 API: URLPattern #100
Dependencies: urlpattern
This PR uses
urlpattern
crate (which was created by Deno developers) to implementURLPattern
.The underlying crate, and thus
URLPattern
as defined here (and also Deno) has difference with the URL Pattern specified: it does not support theignoreCase
option. There is an open PR inurlpattern
to support it, but it is already quite old, and not sure if it will be supported.A single
NativeClass
is introduced (forURLPattern
). For the other components (URLPatternInit
,URLPatternInput
,URLPatternComponentResult
,URLPatternResult
) this PR does not introduce native classes, and instead uses neededTryFromJs
andIntoJs
implementations.Manual testing
Testing
Checklist
make fmt-check
to check)