JC-2379 Clear password and passwordConfirm fields when they're different during new user registration #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent during new user registration
ctapobep
requested changes
Dec 21, 2016
| @@ -341,7 +341,12 @@ public BindingResult register(RegisterUserDto registerUserDto) | |||
| } | |||
|
|
|||
| if(result.hasErrors()) { | |||
| userDto.setPassword(notEncodedPassword); | |||
| if (wrongPasswordConfirmError(result)) { | |||
| removePasswords(registerUserDto); | |||
There was a problem hiding this comment.
Don't think that it's correct to mix layers. TransactionalAuthenticator wouldn't know about form. Proposed method name just for programmer and can tangle.
| @@ -446,5 +451,36 @@ public JCUser storeRegisteredUser(UserDto userDto) { | |||
| LOGGER.info("JCUser registered: {}", user.getUsername()); | |||
| return user; | |||
| } | |||
|
|
|||
|
|
|||
| private void removePasswords(final RegisterUserDto registerUserDto) { | |||
There was a problem hiding this comment.
Please add JavaDocs explaining what this does and why it's needed.
Also, we don't have a habit to put final for local vars and parameters :)
| registerUserDto.getUserDto().setPassword(null); | ||
| } | ||
|
|
||
| private BindingResult removeWrongPasswordConfirmError(BindingResult srcErrors) { |
| @Test | ||
| public void userMustSetToNullPasswordAndPasswordConfirmFieldsWhenTheyAreDifferent() throws Exception { | ||
|
|
||
| Validator customValidator = new Validator() { |
There was a problem hiding this comment.
Why can't you use the usual validator that's used in prod code?
| @@ -486,6 +494,60 @@ public void userMustHaveInitialFieldValuesWhenPluginRegistrationFailWithRegistra | |||
| assertReflectionEquals(expectedRegisterUserDto, registerUserDto); | |||
| } | |||
|
|
|||
| @Test | |||
| public void userMustSetToNullPasswordAndPasswordConfirmFieldsWhenTheyAreDifferent() throws Exception { | |||
There was a problem hiding this comment.
emptiesPassowordAndConfirmationFields_ifTheyDoNotMatch
Maybe let's add some javadocs here explaining why it behaves like this.
| } | ||
|
|
||
| @Test | ||
| public void userMustRestorePasswordAndPasswordConfirmFieldsWhenTheyAreEquals() throws Exception { |
There was a problem hiding this comment.
doesNotEmptyPasswordAndConfirmationFields_ifTheyMatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.