Remove duplicate parse_rinex_nav_file function #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtec
commented
Feb 24, 2025
| @@ -221,11 +224,21 @@ def check_assumptions( | |||
| ) | |||
|
|
|||
|
|
|||
| def parse_rinex_nav_or_obs_file(rinex_file_path: Path): | |||
There was a problem hiding this comment.
This convenience function was actually only used to warm up the parser cache, so moved it here.
jtec
commented
Feb 24, 2025
| @@ -575,7 +575,7 @@ def test_gps_group_delay_multi_prn(input_for_test): | |||
| def test_gal_group_delay(input_for_test): | |||
| """ | |||
| Note that both ephemerides have the same Toe (reference time), but one is I/NAV, the | |||
| other F/NAV. This test implicitly checks whether the right ephemeris is used wben computing | |||
| other F/NAV. This test implicitly checks whether the right ephemeris is used when computing | |||
|
What is the difference between |
@jtec, this question is still valid. I would rather limit the number of submodule files, so why not merge helpers.py and util.py? Unless there is a clear rationale to have both separated files? |
|
@plutonheaven Very good point, I merged |
plutonheaven
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
parse_rinex_nav_fileexisted twice, with slightly different output, likely to work around circular imports. This PR re-arranges some code somewhat so that there is only one.Also merged helpers.py into util.py, as those two have the same job (module with small helper/utility functions) and it's not clear why those functions are divided into two modules.