-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Use junifer-data
datalad dataset for fetching data
#418
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
======================================
Coverage 0.01% 0.01%
======================================
Files 133 133
Lines 5764 5498 -266
======================================
Hits 1 1
+ Misses 5763 5497 -266
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d3cf5d3
to
733110e
Compare
@@ -114,3 +122,96 @@ def get_native_warper( | |||
) | |||
|
|||
return possible_warpers[0] | |||
|
|||
|
|||
def check_dataset() -> dl.Dataset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function needs to check that we are also using/cloning the exact junifer data version that we want.
In our last discussion, we said we will have a subdirectory inside the junifer_data
with the corresponding version to be used with the currently running junifer version.
So somewhere in junifer code, we will have a JUNIFER_DATA_VERSION variable with a string/number/id.
Then we will look if the directory junifer_data/{JUNIFER_DATA_VERSION}
exists, that its a datalad dataset, it's clean and its tag corresponds to JUNIFER_DATA_VERSION.
This way we can keep junifer data for several installed junifer versions, each one consistently using the data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is part of that migration and serves to move manual inconsistent asset downloads to using junifer-data
via datalad. The idea is to move all dataset validating and data fetching machinery to https://github.com/juaml/junifer-data-client and junifer
using its API to fetch data as required using the technique you described. v1.0.0 image of junifer-data
is being built and will be published soon.
The next PR will adapt the usage of junifer-data-client
API while taking care of versions.
…init and registration logic for ParcellationRegistry
6950fcc
to
16c1a16
Compare
Needs to go before #363 |
This PR adapts
junifer-data
datalad dataset at https://github.com/juaml/junifer-data to provide data for junifer.